-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Darjeeling updates #57
Merged
rivos-eblot
merged 58 commits into
lowRISC:ot-darjeeling-8.2.0
from
loiclefort:dj-update-20240301
Mar 1, 2024
Merged
Darjeeling updates #57
rivos-eblot
merged 58 commits into
lowRISC:ot-darjeeling-8.2.0
from
loiclefort:dj-update-20240301
Mar 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When start delay was not defined, the default value was overridden Signed-off-by: Emmanuel Blot <[email protected]>
…mbols. Also add an option to filter CPUs by index. Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Also rework vCPU reference Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Loïc Lefort <[email protected]>
Signed-off-by: Loïc Lefort <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Loïc Lefort <[email protected]>
Generation command could be scheduled by a HW app, i.e. an EDN instance while Instantiation has not yet been completed, as the CSRNG command response of a Generate request was interpreted by the EDN as the completion of the Instantiate command. Signed-off-by: Emmanuel Blot <[email protected]>
The entropy source can give wait time hints to the CSRNG so that the latter does not uselessly poll the former while it is initializing. Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
…ll IPs Signed-off-by: Emmanuel Blot <[email protected]>
The outstanding requests were not discarded on EDN reset Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
… value. This API can be used to ensure the first time IbexIRQ is set, the new IRQ value is propagated to the connected device. The need may arise to forward a 0 value which is otherwise ignored as the role of IbexIRQ is to not propagate updates with unchanged values. Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
It is mandatory to wait for the vCPU to actually stop before resuming the reset sequence. Failing to do so may lead TCG to execute a cached TB from the new PC, updated from reset vector. Avoid using pause_all_vcpus/resume_all_vcpus as other SoCs in the machine should not be stopped. Moreover the virtual clock should not be halted as other SoCs may keep running while the local reset sequence is ran. Avoid using qemu_system_reset_request for the same reason, which is even more intrusive for the whole VM. Signed-off-by: Emmanuel Blot <[email protected]>
…uled Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
…fetch This extension is disabled by default. To enable it, `fetch-ctrl` property should be set. If set, Power Manager IRQ `OT_PWRMGR_HOLDON_FETCH` should be reset to enable the Power Manager Fast FSM to move to the ACTIVE state. Signed-off-by: Emmanuel Blot <[email protected]>
Reset is not a transient state but is now stateful. Signed-off-by: Emmanuel Blot <[email protected]>
Power Manager has diverged between OpenTitan variants. Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
…over DMI Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
This can be useful to observe multiple UART output at once. Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Loïc Lefort <[email protected]>
Signed-off-by: Loïc Lefort <[email protected]>
Signed-off-by: Loïc Lefort <[email protected]>
Signed-off-by: Loïc Lefort <[email protected]>
Passing option "--ci" to ot-format (resp. ot-tidy) will get the list of files to be processed from scripts/opentitan/clang-format.d/*.lst (resp. scripts/opentitan/clang-tidy.d/*.lst) Signed-off-by: Loïc Lefort <[email protected]>
Signed-off-by: Loïc Lefort <[email protected]>
Signed-off-by: Loïc Lefort <[email protected]>
rivos-eblot
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (internal review done)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of fixes and some new features, notably:
-icount