Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fi] Adapt FI code to latest changes #368

Merged
merged 7 commits into from
May 28, 2024
Merged

Conversation

nasahlpa
Copy link
Member

This PR consists of a couple of commits to update the ot-sca FI code to the latest changes in the penetration testing firmware.

nasahlpa added 4 commits May 24, 2024 14:16
This commit renames the crypto_fi_* commands to crypto_* in order to be
consistent with the other (Ibex, OTBN) tests.

Signed-off-by: Pascal Nasahl <[email protected]>
@nasahlpa nasahlpa requested a review from johannheyszl May 24, 2024 13:12
which_test: "crypto_kmac_absorb"
# which_test: "crypto_kmac_squeeze"
# which_test: "crypto_kmac_static"
expected_result: '{"ciphertext":[184,34,91,108,231,47,251,27],"alerts":0,"err_status":0}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the expected result in nasahlpa/opentitan@5371311

expected_result is now:

{"digest":[184,34,91,108,231,47,251,27],"digest_2nd":[142,188,186,201,216,47,203,192],"alerts":[0,0,0],"err_status":0}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks!

Signed-off-by: Pascal Nasahl <[email protected]>
@nasahlpa nasahlpa marked this pull request as ready for review May 24, 2024 13:32
@nasahlpa nasahlpa requested a review from vogelpi as a code owner May 24, 2024 13:32
Copy link
Collaborator

@johannheyszl johannheyszl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nasahlpa and others, e.g. @aewag who have contributed. AFAIK code runs in the tests :)

@nasahlpa nasahlpa requested a review from johannheyszl May 24, 2024 15:35
Copy link
Collaborator

@johannheyszl johannheyszl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all!

@nasahlpa nasahlpa merged commit 6c3e885 into lowRISC:master May 28, 2024
9 checks passed
@nasahlpa nasahlpa deleted the update_cmds branch May 28, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants