Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add test capture #163

Merged
merged 1 commit into from
Sep 28, 2023
Merged

[ci] Add test capture #163

merged 1 commit into from
Sep 28, 2023

Conversation

vrozic
Copy link
Contributor

@vrozic vrozic commented Sep 25, 2023

Test PR adds the first FPGA test to the CI.
The test runs aes-fvsr-key-batch command, collects 1000 measurements on CW310 and publishes the collected traces.

@pamaury
Copy link
Contributor

pamaury commented Sep 25, 2023

There are lots of things missing due to how azure works, here is what it should look like probably:

pr:
  branches:
    include:
    - "*"

- job: sca_capture
  displayName: "Capture SCA traces"
  timeoutInMinutes: 30
  dependsOn: checkout
  pool: FPGA SCA
  steps:
  - checkout: self
  - bash: |
      python3 -m pip install --user -r python-requirements.txt
    displayName: "Install python dependencies"
  - bash: |
      apt install ... # if any
    displayName: "Install system dependencies" 
  - bash: |
      pushd ci
      ./ci_capture_aes_fvsr.sh
      popd
    displayName: "Capture traces" 
  # here migth want to add more steps to publish the traces, e.g.
  - publish: path/to/file
    artifact: traces
    displayName: "Upload traces"

@pamaury
Copy link
Contributor

pamaury commented Sep 25, 2023

also it might need to setup git-lfs if you use it for the tests

@jwnrt
Copy link
Contributor

jwnrt commented Sep 25, 2023

  - bash: |
      apt install ... # if any
    displayName: "Install system dependencies" 

Based on the getting-started guide, I think this should be sudo apt install git-lfs.

ci/azure-pipelines.yml Outdated Show resolved Hide resolved
@vrozic vrozic force-pushed the test-CI branch 2 times, most recently from 2bb4cf0 to 74578c6 Compare September 25, 2023 14:32
ci/azure-pipelines.yml Outdated Show resolved Hide resolved
@vrozic vrozic force-pushed the test-CI branch 4 times, most recently from 1fb06df to 5ad326d Compare September 25, 2023 14:50
@jwnrt
Copy link
Contributor

jwnrt commented Sep 25, 2023

Is the directory definitely called opentitan_simple_aes_data when the project name is opentitan_simple_aes (without the _data)?

@vrozic vrozic force-pushed the test-CI branch 3 times, most recently from cdc4f85 to 865e28f Compare September 26, 2023 10:39
This commit adds the first FPGA test to the CI.
The test captures and publishes 1000 traces using
aes-fvsr-key-batch command.
@vrozic vrozic marked this pull request as ready for review September 26, 2023 12:54
@vrozic vrozic requested review from bilgiday and johannheyszl and removed request for alphan September 27, 2023 17:16
Copy link
Collaborator

@andreaskurth andreaskurth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @vrozic for implementing this and @pamaury and @jwnrt for your feedback 👍

@vrozic vrozic merged commit 2607011 into lowRISC:master Sep 28, 2023
3 checks passed
@jwnrt
Copy link
Contributor

jwnrt commented Sep 28, 2023

Thanks for iterating on this with us @vrozic.

Artifacts are available in the Azure interface for each job, e.g. this run as a link in the logs:

1 artifact produced

which links to this artifact. Not the easiest to discover, I know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants