Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[capture] Remove redundant key write #157

Merged
merged 1 commit into from
Sep 20, 2023
Merged

[capture] Remove redundant key write #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cw/capture.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -892,7 +892,6 @@ def capture_kmac_random(ot, ktp):
"""
key, _ = ktp.next()
tqdm.write(f'Using key: {binascii.b2a_hex(bytes(key))}')
ot.target.simpleserial_write('k', key)
while True:
_, text = ktp.next()
ret = cw.capture_trace(ot.scope, ot.target, text, key, ack=False, as_int=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, makes sense and LGTM!
But how does cw.capture_trace actually send key/text to the device? Also via simpleserial_write()? And how is this handled in kmac_serial.c?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's exactly how it works. capture_trace() uses method set_key() under the hood, which uses simpleserial_write('k', key).
On the kmac_serial.c side, I think that it was just executing the 'k' command twice writing the same key value.
It wasn't slowing down capture by much, but it was still unnecessary.

Expand Down