[capture] Remove redundant key write #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Writing key at the begining of `capture_kmac_random()` is redundant because `cw.capture_trace()` will send the key on every run. Signed-off-by: Vladimir Rozic <[email protected]>
vrozic
requested review from
alphan,
andreaskurth and
vogelpi
as code owners
wettermo
approved these changes
Sep 20, 2023
| @@ -892,7 +892,6 @@ def capture_kmac_random(ot, ktp): | |||
| """ | |||
| key, _ = ktp.next() | |||
| tqdm.write(f'Using key: {binascii.b2a_hex(bytes(key))}') | |||
| ot.target.simpleserial_write('k', key) | |||
| while True: | |||
| _, text = ktp.next() | |||
| ret = cw.capture_trace(ot.scope, ot.target, text, key, ack=False, as_int=True) | |||
There was a problem hiding this comment.
In general, makes sense and LGTM!
But how does cw.capture_trace actually send key/text to the device? Also via simpleserial_write()? And how is this handled in kmac_serial.c?
There was a problem hiding this comment.
That's exactly how it works. capture_trace() uses method set_key() under the hood, which uses simpleserial_write('k', key).
On the kmac_serial.c side, I think that it was just executing the 'k' command twice writing the same key value.
It wasn't slowing down capture by much, but it was still unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing key at the begining of
capture_kmac_random()is redundant becausecw.capture_trace()will send the key on every run.