Cherry-pick to earlgrey_1.0.0: [bazel,otp,manuf] Support immutable ROM_EXT enabling during personalization #24924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This updates the logic to consider both `_ottf_start_address` and `_rom_ext_start_address` when determining the manifest start address. This ensures compatibility with different ELF file formats that generated from linker scripts such as `ottf_silicon_owner_a.ld` and `rom_ext_slot_a.ld`, which may use either symbol to represent the start address of the ROM_EXT section. This also introduces a new feature that conditionally updates the OTP JSON file with data from immutable ROM_EXT section. This update is performed only if the immutable ROM_EXT is enabled. Signed-off-by: Anthony Chen <[email protected]> (cherry picked from commit 1e0e055)
This separates the provisioning of the IMMUTABLE_ROM_EXT_EN OTP field from the rest of the CREATOR_SW_CFG partition. This is necessary because the personalization firmware doesn't include an immutable ROM_EXT section. Enabling immutable ROM_EXT earlier would prevent the personalization firmware from being executed. This also builds personalization firmware using the ROM_EXT immutable section OTP generation tool by default. Signed-off-by: Anthony Chen <[email protected]> (cherry picked from commit e8897b0)
github-actions
bot
requested review from
alees24
and removed request for
a team
timothytrippel
requested review from
moidx and
timothytrippel
and removed request for
alees24
timothytrippel
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic cherry-pick of #24826 to branch
earlgrey_1.0.0.