[bazel,otp,manuf] Support immutable ROM_EXT enabling during personalization #24826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonychen1251
requested review from
engdoreis
and removed request for
a team
anthonychen1251
force-pushed
the
support-provision-im-ext-during-perso
branch
2 times, most recently
from
f66a3ce to
d44c7ea
Compare
anthonychen1251
force-pushed
the
support-provision-im-ext-during-perso
branch
2 times, most recently
from
db8a611 to
7dce6c3
Compare
anthonychen1251
force-pushed
the
support-provision-im-ext-during-perso
branch
from
7dce6c3 to
83cd624
Compare
timothytrippel
approved these changes
Oct 22, 2024
| * @return OK_STATUS if the IMMUTABLE_ROM_EXT_EN field was provisioned. | ||
| */ | ||
| OT_WARN_UNUSED_RESULT | ||
| status_t manuf_individualize_device_immutable_rom_ext_en_cfg( |
There was a problem hiding this comment.
Just a thought here, since we now have a separate function for setting the:
- flash_data_default_cfg
- manuf_state
- immutable_rom_ext_en
- rom_bootstrap_dis
perhaps we could combine these into a one function that take as inputs: - the OTP partition
- the field / offset to program
?
This would consolidate a lot of very similar functionality. Ok to do in a follow up PR, or additional commit on this PR if you would like.
There was a problem hiding this comment.
Thanks for the suggestion. That's a good improvement. If you don't mind, I could include this in the PR for #24617
This updates the logic to consider both `_ottf_start_address` and `_rom_ext_start_address` when determining the manifest start address. This ensures compatibility with different ELF file formats that generated from linker scripts such as `ottf_silicon_owner_a.ld` and `rom_ext_slot_a.ld`, which may use either symbol to represent the start address of the ROM_EXT section. This also introduces a new feature that conditionally updates the OTP JSON file with data from immutable ROM_EXT section. This update is performed only if the immutable ROM_EXT is enabled. Signed-off-by: Anthony Chen <[email protected]>
anthonychen1251
force-pushed
the
support-provision-im-ext-during-perso
branch
from
83cd624 to
59ae706
Compare
anthonychen1251
force-pushed
the
support-provision-im-ext-during-perso
branch
from
59ae706 to
1f73ea3
Compare
|
The CI pipeline was failing (task: |
This separates the provisioning of the IMMUTABLE_ROM_EXT_EN OTP field from the rest of the CREATOR_SW_CFG partition. This is necessary because the personalization firmware doesn't include an immutable ROM_EXT section. Enabling immutable ROM_EXT earlier would prevent the personalization firmware from being executed. This also builds personalization firmware using the ROM_EXT immutable section OTP generation tool by default. Signed-off-by: Anthony Chen <[email protected]>
anthonychen1251
force-pushed
the
support-provision-im-ext-during-perso
branch
from
1f73ea3 to
e8897b0
Compare
timothytrippel
added
the
CherryPick:earlgrey_1.0.0
|
Successfully created backport PR for |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two commits that:
_rom_ext_start_addresswhen determining the manifest start address to support the common rom_ext binaryThis PR addresses #24610 partially.
Note: this depends on #24783 and #24789. Only review the last 2 commits.