[manuf] Finalize {Creator,Owner}SwCfg at end of perso flow #24783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This calculates the measurement of the OTP partitions in `ft_personalize` and pass them to `dice_uds_tbs_cert_build()`. This change is necessary because the CreatorSwCfg and OwnerSwCfg might not be fully provisioned to the OTP when building the UDS certification. By calculating the final measurements in `ft_personalize`, we can get the values of unprovisioned field from the OTP image to ensure the correct values are used in the certificate generation process. Signed-off-by: Anthony Chen <[email protected]>
anthonychen1251
requested review from
pamaury and
timothytrippel
and removed request for
a team
anthonychen1251
force-pushed
the
adjust-sw-cfg-provision-flow
branch
from
b5f7fa4 to
96cff1c
Compare
anthonychen1251
force-pushed
the
adjust-sw-cfg-provision-flow
branch
from
96cff1c to
7f994b6
Compare
This modifies the perso flow to complete the provisioning of the CreatorSwCfg and OwnerSwCfg OTP partitions at the end of the process. This ensures that the perso firmware can be reentrant in case of unexpected resets during personalization. Previously, these partitions were provisioned earlier in the flow. However, since we are going to bind the perso firmware with `CREATOR_SW_CFG_MANUF_STATE`, we need to ensure that this field is provisioned as late as possible. Since CreatorSwCfg and OwnerSwCfg partitions are now not fully provisioned in the OTP during the UDS certificate generation process, overwrite the fields that are not provisioned until the end of personalization process with the values from the OTP image. At the end of perso flow, compare the OTP measurement used during certificate generation with the digest stored in the OTP. Ensure that the UDS certificate was generated using the correct OTP values. Signed-off-by: Anthony Chen <[email protected]>
anthonychen1251
force-pushed
the
adjust-sw-cfg-provision-flow
branch
from
7f994b6 to
1404534
Compare
|
The failed test runs |
timothytrippel
approved these changes
Oct 19, 2024
timothytrippel
added
the
CherryPick:earlgrey_1.0.0
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin earlgrey_1.0.0
git worktree add -d .worktree/backport-24783-to-earlgrey_1.0.0 origin/earlgrey_1.0.0
cd .worktree/backport-24783-to-earlgrey_1.0.0
git switch --create backport-24783-to-earlgrey_1.0.0
git cherry-pick -x dbd0a4a1a8cadb88d6800552b4908e27409030e3 1404534e9ca1949acc6bd443c824af22f40377f2 |
github-actions
bot
added
the
Manually CherryPick
timothytrippel
added
CherryPick:earlgrey_1.0.0
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin earlgrey_1.0.0
git worktree add -d .worktree/backport-24783-to-earlgrey_1.0.0 origin/earlgrey_1.0.0
cd .worktree/backport-24783-to-earlgrey_1.0.0
git switch --create backport-24783-to-earlgrey_1.0.0
git cherry-pick -x dbd0a4a1a8cadb88d6800552b4908e27409030e3 1404534e9ca1949acc6bd443c824af22f40377f2 |
github-actions
bot
added
the
Manually CherryPick
timothytrippel
added
CherryPick:earlgrey_1.0.0
|
Successfully created backport PR for |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two commits that:
Move the calculation of OTP measurement from
dice_uds_tbs_cert_buildtoft_personalizeModify the perso flow to complete the provisioning of the
CreatorSwCfgandOwnerSwCfgOTP partitions at the end of the process.This PR addresses #24610 partially.