-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hw,dma,rtl] Remove memory limit interrupt #24102
[hw,dma,rtl] Remove memory limit interrupt #24102
Conversation
8b51715
to
2fc5644
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: I haven't tried to re-run any tests and checked that this completely removes all traces of that interrupt and that everything seems work, having not worked on Darjeeling for a while.
2fc5644
to
db72eeb
Compare
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
db72eeb
to
936c7d9
Compare
The full regression suite is passing:
|
CHANGE AUTHORIZED: hw/ip/dma/data/dma.hjson |
The memory interrupt allowed the system to configure a soft and hard memory limit address. When reaching one of those limits during a DMA transfer, the DMA would fire the associated interrupt. This mode was originally designed for the hardware-handshake mode, wehere the DMA would run in a free-running approach and SW would stop the transfer manually when reaching one of those limits.
In the current design, this mode is superseded by the multi-chunk mode, where a precise number of bytes gets transferred automatically.
This PR removes that interrupt from: