Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csrng] Move CSRNG version 2.0.0 verification_stage to V2S #23933

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

vogelpi
Copy link
Contributor

@vogelpi vogelpi commented Jul 5, 2024

This resolves #22467.

@vogelpi vogelpi requested review from h-filali and andreaskurth July 5, 2024 12:29
@vogelpi vogelpi mentioned this pull request Jul 5, 2024
@vogelpi
Copy link
Contributor Author

vogelpi commented Jul 5, 2024

CHANGE AUTHORIZED: hw/ip/csrng/data/csrng.hjson

This PR just updates the verification stage without impact on the RTL.

Copy link
Contributor

@andreaskurth andreaskurth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on this V2S analysis and its review. Great work!

@andreaskurth
Copy link
Contributor

CHANGE AUTHORIZED: hw/ip/csrng/data/csrng.hjson

@vogelpi
Copy link
Contributor Author

vogelpi commented Jul 5, 2024

Thanks @andreaskurth ! And thanks @h-filali for the great work on the entropy complex, I am merging this. The PR doesn't not affect the FPGA tests in any way.

@vogelpi vogelpi merged commit 5b9568d into lowRISC:master Jul 5, 2024
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[csrng] V2S Signoff
2 participants