-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[csrng] V2S Signoff #22467
Comments
Discussed moving as P1 to M5 due to RTL risk analysis performed during last issue triage. |
I will collect the required information and update the issue on THU. In short, we almost signed of CSRNG at V2S as part of M2 but had to signoff at V1 instead for the following reason:
This drop occurred a long time ago and unrelated to the M2 work. It's tracked in #19033 and @h-filali is investigating this (he'll return tomorrow). |
Commits since Earlgrey-PROD.M2For Commits since Earlgrey-ES tapeout, see #20976 (comment) .
Issues closed since Earlgrey-PROD.M2For issues closed since Earlgrey-ES tapeout, see #20976 (comment)
Currently open issues
Coverage report from 2024-07-03Two V2 sequences (csrng_intr_vseq, csrng_err_vseq, csrng_cmds) have a pass rate below 100% and thus show as failing in the overview. However, all tests have a pass rate above the 90% threshold required for V2S. The only exception is the V3 stress_all_with_rand_reset test. All coverage metrics are above the 90% V2(S) threshold. SummaryBetween M2 and now, there have been some RTL and DV changes to implement missing but important features and improve the error handling as well as for increasing coverage metrics. The most important RTL PRs were
All relevant DV work for V2S has been done and I suggest to sign off CSRNG at V2S. Do you share this view @andreaskurth and @h-filali ? |
@h-filali , I've now updated the sign-off issue / comment above to reflect the latest changes. Would mind reviewing this please? |
@vogelpi I double checked the dashboard and I agree. The coverage metrics are all above 90% and the failing tests consist of mainly stress_all_with_rand_reset which is V3 and some rare failures on other tests (<6%). This has been consistently the case for multiple weeks (apart from where we had some general regression issues). |
This resolves lowRISC#22467. Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>
Upstream OpenTitan commit 5b9568d058bed157328a1564a7f11d1ac45bec9b This resolves lowRISC/opentitan#22467. The following files are changed in OpenTitan commit but not included: - hw/ip/csrng/doc/checklist.md Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org> Co-authored-by: Gary Guo <gary.guo@lowrisc.org> Signed-off-by: Gary Guo <gary.guo@lowrisc.org>
No description provided.
The text was updated successfully, but these errors were encountered: