[sival,alert] Enable alert_handler_lpg_sleep_mode_pings test in sival environments
#22994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jwnrt
commented
May 7, 2024
jwnrt
commented
- Added the sival test environments, but kept Verilator disabled.
- Changed the platform-dependent handling to a switch/case to make the verilator case clearer.
- Added a case for silicon.
Also changes how un-accounted for platforms are handled by failing the test. FPGA support is extended to the CW340. Signed-off-by: James Wainwright <[email protected]>
moidx
reviewed
May 9, 2024
Also changes the delay for the DV version to match. Signed-off-by: James Wainwright <[email protected]>
jwnrt
force-pushed
the
sival-alert-handler-lpg-sleep-mode-pings
branch
from
b22c914 to
7d055a3
Compare
|
Failing on the FPGA because of #23038 |
|
Closed because it’s against an old branch, will need redoing on |
jwnrt
added
CherryPick:earlgrey_1.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.