[Sival, rstmgr] Fix rstmgr_alert_info_test on ROM_EXT #22795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engdoreis
force-pushed
the
sival_rstmgr_fix
branch
3 times, most recently
from
d164d14 to
3ec76bf
Compare
engdoreis
changed the title
engdoreis
requested review from
moidx,
matutem and
a-will
and removed request for
a team
engdoreis
force-pushed
the
sival_rstmgr_fix
branch
2 times, most recently
from
14eeaba to
426df7e
Compare
engdoreis
commented
Apr 24, 2024
| @@ -701,6 +701,12 @@ static void init_expected_cause(void) { | |||
| .alert_info.alert_cause[kTopEarlgreyAlertIdI2c0FatalFault] = 1; | |||
| kExpectedInfo[kRound3] | |||
| .alert_info.alert_cause[kTopEarlgreyAlertIdSpiHost0FatalFault] = 1; | |||
|
|
|||
| if (kBootStage == kBootStageOwner && | |||
There was a problem hiding this comment.
On Round 3 all the alerts are enabled, after the reset is caused by the alert handler escalation, a kTopEarlgreyAlertIdFlashCtrlFatalErr happens during the boot, only with FGPA + ROM_EXT.
This doesn't happen on Silicon, probably because the Creator and Owner secrets are there, but I'm not sure why it happens on the FPGA.
@cfrantz Could you please check that this is not a bug with ROM_EXT?
engdoreis
force-pushed
the
sival_rstmgr_fix
branch
from
426df7e to
67d6a7c
Compare
moidx
approved these changes
Apr 29, 2024
| CHECK_DIF_OK(dif_alert_handler_irq_set_enabled( | ||
| &alert_handler, kDifAlertHandlerIrqClassb, kDifToggleEnabled)); | ||
| } else { | ||
| LOG_INFO("Skipping OTP test due to ROM_EXT"); |
There was a problem hiding this comment.
nit: Skipping OTP test due to ROM_EXT ePMP configuration
engdoreis
force-pushed
the
sival_rstmgr_fix
branch
from
67d6a7c to
3779600
Compare
Signed-off-by: Douglas Reis <[email protected]>
engdoreis
force-pushed
the
sival_rstmgr_fix
branch
from
3779600 to
32d2c5c
Compare
The ROM_EXT locks up the OTP registers with the ePMP, any write attempt to them would generate an exception. Therefore we can't test OTP alerts when the test runs after the ROM_EXT. Signed-off-by: Douglas Reis <[email protected]>
The test generates a kTopEarlgreyAlertIdFlashCtrlFatalErr alert only on the FPGA and with ROM_EXT. It doesn't happens on Silicon probrably because it has the seeds. Signed-off-by: Douglas Reis <[email protected]>
Signed-off-by: Douglas Reis <[email protected]>
engdoreis
force-pushed
the
sival_rstmgr_fix
branch
from
2123499 to
00a19c9
Compare
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin master
git worktree add -d .worktree/backport-22795-to-master origin/master
cd .worktree/backport-22795-to-master
git switch --create backport-22795-to-master
git cherry-pick -x 9836ff68262144b4289a03dfcd7962ed80367056 6e21981a7430f057070e788a5d9ebcb74c83bd09 7be7335ffbd1d5097c8c141718fce8c4a58dee20 00a19c96a6d233bb48dd423b29f61a0e0bb5bd7e |
jwnrt
added
the
CherryPick:earlgrey_1.0.0
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin master
git worktree add -d .worktree/backport-22795-to-master origin/master
cd .worktree/backport-22795-to-master
git switch --create backport-22795-to-master
git cherry-pick -x 9836ff68262144b4289a03dfcd7962ed80367056 6e21981a7430f057070e788a5d9ebcb74c83bd09 7be7335ffbd1d5097c8c141718fce8c4a58dee20 00a19c96a6d233bb48dd423b29f61a0e0bb5bd7e |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin earlgrey_1.0.0
git worktree add -d .worktree/backport-22795-to-earlgrey_1.0.0 origin/earlgrey_1.0.0
cd .worktree/backport-22795-to-earlgrey_1.0.0
git switch --create backport-22795-to-earlgrey_1.0.0
git cherry-pick -x 9836ff68262144b4289a03dfcd7962ed80367056 6e21981a7430f057070e788a5d9ebcb74c83bd09 7be7335ffbd1d5097c8c141718fce8c4a58dee20 00a19c96a6d233bb48dd423b29f61a0e0bb5bd7e |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin master
git worktree add -d .worktree/backport-22795-to-master origin/master
cd .worktree/backport-22795-to-master
git switch --create backport-22795-to-master
git cherry-pick -x 9836ff68262144b4289a03dfcd7962ed80367056 6e21981a7430f057070e788a5d9ebcb74c83bd09 7be7335ffbd1d5097c8c141718fce8c4a58dee20 00a19c96a6d233bb48dd423b29f61a0e0bb5bd7e |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin earlgrey_1.0.0
git worktree add -d .worktree/backport-22795-to-earlgrey_1.0.0 origin/earlgrey_1.0.0
cd .worktree/backport-22795-to-earlgrey_1.0.0
git switch --create backport-22795-to-earlgrey_1.0.0
git cherry-pick -x 9836ff68262144b4289a03dfcd7962ed80367056 6e21981a7430f057070e788a5d9ebcb74c83bd09 7be7335ffbd1d5097c8c141718fce8c4a58dee20 00a19c96a6d233bb48dd423b29f61a0e0bb5bd7e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20589
The Root cause was that the ROM_EXT locks up the OTP registers with the ePMP, any attempt to write to them would generate an exception.
Therefore, we can't test the OTP alert when the test runs after the ROM_EXT.