ROM cleanups and fixes #22398
Open
ROM cleanups and fixes #22398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sameo
commented
Apr 3, 2024
•
sameo
commented
- Remove the AST copy from the base ROM startup code
- Remove one extra CFI counter increment
- Typo fix for the ROM1 base address in tb.sv
Signed-off-by: Samuel Ortiz <[email protected]>
Integrated has custom AST IP blocks and blindly copying the AST OTP values in the AST memory mapped region may generate undefined behaviour. Signed-off-by: Samuel Ortiz <[email protected]>
Signed-off-by: Samuel Ortiz <[email protected]>
sameo
force-pushed
the
topic/rom-cleanup
branch
from
5a9f023 to
0a5d9ad
Compare
rswarbrick
reviewed
Apr 15, 2024
There was a problem hiding this comment.
This all seems reasonable, but I'm not sure I've got enough background info to review it properly.
For the second patch in particular ("Remove AST initialization"), do we have a document that explains what the ROM is supposed to be doing at this point? Presumably, something else has configured the AST already? Does any OT software or hardware have to do anything?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.