[cryptotest] Add ECDSA host-side test harness #21113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 30, 2024
RyanTorok
force-pushed
the
cryptotest-ecdsa-driver
branch
from
10bf07f to
e8d09e1
Compare
RyanTorok
changed the title
RyanTorok
force-pushed
the
cryptotest-ecdsa-driver
branch
from
e8d09e1 to
dcd75b6
Compare
RyanTorok
changed the title
RyanTorok
force-pushed
the
cryptotest-ecdsa-driver
branch
from
dcd75b6 to
194badd
Compare
pamaury
reviewed
Feb 15, 2024
| // clang-format off | ||
|
|
||
| #define ECDSA_OPERATION(_, value) \ | ||
| value(_, Verify) |
There was a problem hiding this comment.
It would be nice to document what is expected to follow the Verify device and what does the device answer. For example:
// Following a Verify command, the host is expected to send a `CryptotestEcdsaMessage`,
// a `CryptotestEcdsaSignature` to verify, two `CryptotestEcdsaCoordinate` (I assume the public key).
// The device will respond with a `CryptotestEcdsaVerifyOutput`.
pamaury
approved these changes
Feb 15, 2024
jadephilipoom
approved these changes
Feb 19, 2024
Signed-off-by: Ryan Torok <[email protected]>
RyanTorok
force-pushed
the
cryptotest-ecdsa-driver
branch
from
194badd to
d249885
Compare
milesdai
approved these changes
Feb 20, 2024
RyanTorok
added
the
CherryPick:earlgrey_es_sival
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the host-side Rust test harness for the ECDSA
Verifyoperation tests and the associated uJSON C header file. The device-side firmware will be included in #20853.Dependent on #21112 and #21114