[cryptotest] Test harness for SPHINCS+ verify operation w/ SHA-2 #21681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanTorok
requested review from
alees24,
jadephilipoom and
milesdai
and removed request for
a team
RyanTorok
added
the
CherryPick:earlgrey_es_sival
RyanTorok
force-pushed
the
cryptotest-sphincsplus-harness
branch
from
0ca359a to
5e58ff8
Compare
RyanTorok
force-pushed
the
cryptotest-sphincsplus-harness
branch
from
5e58ff8 to
e3bf1a8
Compare
RyanTorok
force-pushed
the
cryptotest-sphincsplus-harness
branch
from
e3bf1a8 to
20dee7f
Compare
RyanTorok
changed the title
|
Updated this PR to use the test vectors for SPX w/ SHA-2 instead of SHAKE, since this was changed in ROM in #23732 . |
23732 switched SPHINCS+ to use SHA-2 instead of SHAKE. This commit adds a new bazel rule to fetch the test vector zip file that was uploaded to the GCP bucket to test the new configuration. Signed-off-by: Ryan Torok <[email protected]>
Signed-off-by: Ryan Torok <[email protected]>
Signed-off-by: Ryan Torok <[email protected]>
Signed-off-by: Ryan Torok <[email protected]>
RyanTorok
force-pushed
the
cryptotest-sphincsplus-harness
branch
from
20dee7f to
4710c16
Compare
jadephilipoom
approved these changes
Jul 8, 2024
cfrantz
approved these changes
Jul 8, 2024
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin earlgrey_es_sival
git worktree add -d .worktree/backport-21681-to-earlgrey_es_sival origin/earlgrey_es_sival
cd .worktree/backport-21681-to-earlgrey_es_sival
git switch --create backport-21681-to-earlgrey_es_sival
git cherry-pick -x 6eb738f7bed0397485fe93450b57432984a9c1f4 74ae6d87ae43b40b38dfb1fac002eb91e9c32fbd 677e063d7eea67df7f5a3f866b6fd0b32f1c83f9 4710c1613aa29ac3d1880217b91b3caabb4af67f |
github-actions
bot
added
the
Manually CherryPick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #21680. Adds a test harness for SPHINCS+ verify operation tests w/ SHAKE-256 in the style of the test harnesses for the algorithms in cryptolib. Structurally, the test harness has a lot in common with the ECDSA harness in #21113 and #20853, except that there is no elliptic curve parameter.
[Resolved] The dependency on #22953 exists because this PR switches the test vectors to use the
consistent-basewversion of SPHINCS+.Dependent on #21680Dependent on #22953