Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] add rust-crypto crate (used by ECDSA test harness) #21112

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

RyanTorok
Copy link
Contributor

This PR adds the rust-crypto crate as a dependency. It is currently used to implement the host-side hashing operation for the ECDSA Verify tests (see #20853), and will soon be used to test the Sign operation as well by performing the verify operation on the host-side.

@RyanTorok RyanTorok marked this pull request as ready for review January 30, 2024 18:10
@RyanTorok RyanTorok requested a review from cfrantz as a code owner January 30, 2024 18:10
@RyanTorok RyanTorok force-pushed the add-rust-crypto branch 2 times, most recently from 0e39336 to 8e11a51 Compare February 12, 2024 22:17
Copy link
Contributor

@cfrantz cfrantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @pamaury Was going to investigate adding some ecdsa commands to opentitantool for host-side keygen/sign/verify operations.

Make sure you both coordinate so we don't duplicate work.

@cfrantz cfrantz added the CherryPick:earlgrey_es_sival This PR should be cherry-picked to earlgrey_es_sival label Feb 13, 2024
@RyanTorok
Copy link
Contributor Author

Rebased to master to run remaining CI checks

@milesdai milesdai merged commit 93b7cb9 into lowRISC:master Feb 14, 2024
32 checks passed
Copy link

Backport failed for earlgrey_es_sival, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin earlgrey_es_sival
git worktree add -d .worktree/backport-21112-to-earlgrey_es_sival origin/earlgrey_es_sival
cd .worktree/backport-21112-to-earlgrey_es_sival
git switch --create backport-21112-to-earlgrey_es_sival
git cherry-pick -x 5a2b250801b5fe781486ce5d47068c2ba3c15c0f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPick:earlgrey_es_sival This PR should be cherry-picked to earlgrey_es_sival
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants