[sival,rstmgr] Adjust rstmgr_alert_info_test #20907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matutem
force-pushed
the
rstmgr_alert_info
branch
2 times, most recently
from
42e9e30 to
9ee5753
Compare
matutem
force-pushed
the
rstmgr_alert_info
branch
from
9ee5753 to
1a73248
Compare
moidx
approved these changes
Jan 24, 2024
| } | ||
| } | ||
|
|
||
| void flash_ctrl_show_faults(const dif_flash_ctrl_state_t *flash_ctrl) { |
There was a problem hiding this comment.
I like this function! It may be useful to have in flash_ctrl_testutils.
A minor cleanup of the test to expect an otp_ctrl error if not in rom_ext. There is still an unexpected flash_ctrl read error for cw310 upon entry to test_main, so it is pending from rom_ext. Add utility to log the bits set in flash_ctrl fault status. The issue lowRISC#20589 has an explanation of this test's failures. Signed-off-by: Guillermo Maturana <[email protected]>
matutem
force-pushed
the
rstmgr_alert_info
branch
from
1a73248 to
e61d18f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor cleanup of the test to expect an otp_ctrl error if not
in rom_ext. There is still an unexpected flash_ctrl read error
for cw310 upon entry to test_main, so it is pending from rom_ext.
Add utility to log the bits set in flash_ctrl fault status.
The issue #20589 has an explanation of this test's failures.