[sw/silicon_creator] Add SFDP table definition and READ_SFDP command #11742
Conversation
alphan
force-pushed
the
spi-device-sfdp
branch
2 times, most recently
from
e58cc40 to
9f508fa
Compare
alphan
requested review from
timothytrippel,
a-will and
eunchan
and removed request for
a team
|
@eunchan, can you take a quick look at the changes in |
|
Yep . Looks good to me Thanks! |
There was a problem hiding this comment.
LGTM, but I will defer to @a-will's judgment given his experience with the spi_device DIFs.
Signed-off-by: Alphan Ulusoy <[email protected]>
| .address = false, | ||
| .dummy_cycles = 0, | ||
| }); | ||
| // Configure READ_SFDP command (CMD_INFO_4). |
There was a problem hiding this comment.
Just a comment: I wonder if we ought to have regtool generate constants / macros that associate cmd_info slots with the specific hardware-handled commands.
| /** | ||
| * BFPT 17th Word | ||
| * -------------- | ||
| * [31: 0]: Fast read (1S-8S-8S) (1S-1S-8S) (not supported, 0x0) | ||
| */ | ||
| #define BFPT_WORD_17(X) \ | ||
| X(31, 0, kBfptNotSupported) |
There was a problem hiding this comment.
nit: Given the non-support of anything past word 16, one wonders if we should find a JEDEC parameter table version that doesn't include words [17..23] and use that version and save a bit of parameter space.
There was a problem hiding this comment.
I agree. I'll try to find something from a credible source when I get the chance but jedec.org is not very helpful when it comes to previous versions of the specs.
This PR adds the initial definition of the SFDP table that OpenTitan will use and the READ_SFDP command. The values are from the doc (SFDP and the BFPT headers) and the spreadsheet (basic flash parameters table) that I've been working on.
Following issues track some open items:
READ_SFDPresponse seem to be incorrect).Signed-off-by: Alphan Ulusoy [email protected]