Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spi_device] Auto-generated macros for reserved areas in the buffer #11740

Closed
alphan opened this issue Mar 28, 2022 · 3 comments · Fixed by #20942
Closed

[spi_device] Auto-generated macros for reserved areas in the buffer #11740

alphan opened this issue Mar 28, 2022 · 3 comments · Fixed by #20942
Assignees
Labels
Component:Tooling Issues related to tooling, e.g. tools/scripts for doc, code generation (docgen, reggen), CSR Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones IP:spi_device Type:Enhancement Feature requests, enhancements Type:Icebox Changes deferred to future milestones

Comments

@alphan
Copy link
Contributor

alphan commented Mar 28, 2022

It would be nice to have auto-generated macros for the offset (0xc00) and size (256 bytes) of the SFDP area in spi_device_regs.h and some documentation.

@a-will's comment: I wonder if we ought to have regtool generate constants / macros that associate cmd_info slots with the specific hardware-handled commands.

Update: Also for payload buffer (0xd00) and size.

@alphan alphan added the Type:Enhancement Feature requests, enhancements label Mar 28, 2022
@alphan alphan changed the title [spi_device] Auto-generated macros for the SFDP area in the buffer [spi_device] Auto-generated macros for reserved areas in the buffer Mar 29, 2022
@alphan
Copy link
Contributor Author

alphan commented Jun 13, 2022

@eunchan These constants are grouped together here. It would be great if we could have these in spi_device_regs.h for ease of maintenance.

@eunchan
Copy link
Contributor

eunchan commented Jun 13, 2022

Let me think about this. Not sure defining the items as parameters in spi_device.hjson is enough or not.

@eunchan eunchan added Component:Tooling Issues related to tooling, e.g. tools/scripts for doc, code generation (docgen, reggen), CSR Type:FutureRelease Not relevant to currently planned releases/milestones labels Aug 18, 2022
@andreaskurth
Copy link
Contributor

Triaged for spi_device. If I understand correctly, we have the information we need but it would be nice to autogenerate it, so I think we can resolve this post M2.5 --> Type:Icebox Changes deferred to future milestones .

@andreaskurth andreaskurth added Type:Icebox Changes deferred to future milestones Triaged and removed Type:FutureRelease Not relevant to currently planned releases/milestones labels Feb 24, 2023
@msfschaffner msfschaffner added the Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones label Oct 6, 2023
@msfschaffner msfschaffner added this to the Backlog milestone Oct 6, 2023
@msfschaffner msfschaffner modified the milestones: Backlog, Earlgrey-PROD.M5 Nov 3, 2023
@msfschaffner msfschaffner linked a pull request Jan 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:Tooling Issues related to tooling, e.g. tools/scripts for doc, code generation (docgen, reggen), CSR Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones IP:spi_device Type:Enhancement Feature requests, enhancements Type:Icebox Changes deferred to future milestones
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants