Skip to content

Commit

Permalink
[rom_ctrl, rtl] Conditional coverage hole
Browse files Browse the repository at this point in the history
There is a removal of an item (reqfifo_rvalid) from the conditional statement
to deduct coverage hole 1011.We can't see dvalid & !reqfifo_rvalid. Reason
being if d_valid is true then reqfifo_rvalid must be true. Similarly, if
reqfifo_rvalid is false, then we can't see d_valid high.

Signed-off-by: Kinza Qamar <[email protected]>
  • Loading branch information
KinzaQamar committed Dec 8, 2024
1 parent 7ed46b1 commit 81a875e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hw/ip/tlul/rtl/tlul_adapter_sram.sv
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ module tlul_adapter_sram
end

logic vld_rd_rsp;
assign vld_rd_rsp = d_valid & reqfifo_rvalid & rspfifo_rvalid & (reqfifo_rdata.op == OpRead);
assign vld_rd_rsp = d_valid & rspfifo_rvalid & (reqfifo_rdata.op == OpRead);
// If the response data is not valid, we set it to an illegal blanking value which is determined
// by whether the current transaction is an instruction fetch or a regular read operation.
logic [top_pkg::TL_DW-1:0] error_blanking_data;
Expand Down

0 comments on commit 81a875e

Please sign in to comment.