Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecc fix #2190

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Ecc fix #2190

merged 3 commits into from
Jul 15, 2024

Conversation

GregAC
Copy link
Collaborator

@GregAC GregAC commented Jul 15, 2024

No description provided.

GregAC added 3 commits July 15, 2024 21:19
Under certain circumstances Ibex ignored the ECC check from the register
file when it should not have. This fixes the issue.

Fixes lowRISC#2188
Previously the riscv_rf_intg_test skipped certain scenarios where an ECC
error from the register file should trigger an alert. This change stops
it from skipping those scenarios.
This enables more scenarios begin stimulated per regression run around
RF ECC errors.
@GregAC GregAC requested review from andreaskurth and vogelpi July 15, 2024 20:20
Copy link
Contributor

@vogelpi vogelpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @GregAC !

@GregAC
Copy link
Collaborator Author

GregAC commented Jul 15, 2024

Bypassing CI due to a stuck runner. Local runs have been done to check the relevant regressions are clean.

@GregAC GregAC merged commit 96a1c02 into lowRISC:master Jul 15, 2024
4 of 5 checks passed
@GregAC GregAC deleted the ecc_fix branch July 15, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants