Mem response agent fix #2177
Merged
Mem response agent fix #2177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregAC
force-pushed
the
mem_response_agent_fix
branch
from
92f908e to
e231721
Compare
rswarbrick
reviewed
Jun 21, 2024
| cfg.vif.response_driver_cb.rvalid <= 1'b0; | ||
| cfg.vif.response_driver_cb.rdata <= 'x; | ||
| cfg.vif.response_driver_cb.rintg <= 'x; | ||
| cfg.vif.response_driver_cb.error <= 'x; | ||
| rdata_queue.get(tr); | ||
| if(cfg.vif.response_driver_cb.reset) continue; | ||
| cfg.vif.wait_clks(tr.rvalid_delay); | ||
|
|
||
| for (int i = 0;i < tr.rvalid_delay; ++i) begin |
There was a problem hiding this comment.
Nit: Missing space after ';'. But I'd suggest repeat (tr.rvalid_delay) anyway.
rswarbrick
approved these changes
Jun 21, 2024
Previous code working with clocking blocks synced to the raw clock event. Instead they should sync to the clocking block event. This ensures the values being read are the latest values rather than a cycle old. In particular for ibex_mem_intf_agent this meant it was unable to produce a single cycle response to any memory transaction. With this fix these are now observed.
GregAC
force-pushed
the
mem_response_agent_fix
branch
from
e231721 to
8a0c3f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.