-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscriptions, mutations, and the counter
example
#16
base: main
Are you sure you want to change the base?
Conversation
The client library we expect users to load in Web frontends is built alongside the browser extension, so the communication protocol between that library and the extension is now encapsulated: the only public API we need to keep stable is the TypeScript API of the library, and developers can pull in the library using their JavaScript package manager of choice. The client worker is now its own package independent of the extension: this should make it easier to build demos like the where the client is embedded directly into the frontend and the user gets a throwaway wallet to play with.
"author": "", | ||
"license": "ISC" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we populate this, or are we planning on doing that later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! 🎉
@@ -0,0 +1,24 @@ | |||
# Logs | |||
logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to make these rules available on all sub-directories starting from the repository root?
let chain_id = client_context | ||
.wallet() | ||
.default_chain() | ||
.expect("No default chain"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional nit:
.expect("No default chain"); | |
.expect("A default chain should be configured"); |
Atop #10.
Adds support for subscriptions and mutations, as well as a frontend for the
linera-protocol
counter
example that demonstrates the usage of both.