Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriptions, mutations, and the counter example #16

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Twey
Copy link
Collaborator

@Twey Twey commented Nov 25, 2024

Atop #10.

Adds support for subscriptions and mutations, as well as a frontend for the linera-protocol counter example that demonstrates the usage of both.

client/src/lib.rs Outdated Show resolved Hide resolved
@Twey Twey mentioned this pull request Nov 26, 2024
client/src/lib.rs Outdated Show resolved Hide resolved
The client library we expect users to load in Web frontends is built
alongside the browser extension, so the communication protocol between
that library and the extension is now encapsulated: the only public
API we need to keep stable is the TypeScript API of the library, and
developers can pull in the library using their JavaScript package
manager of choice.

The client worker is now its own package independent of the extension:
this should make it easier to build demos like the where the client is
embedded directly into the frontend and the user gets a throwaway
wallet to play with.
Comment on lines +15 to +16
"author": "",
"license": "ISC"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we populate this, or are we planning on doing that later?

Copy link

@jvff jvff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! 🎉

@@ -0,0 +1,24 @@
# Logs
logs
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to make these rules available on all sub-directories starting from the repository root?

let chain_id = client_context
.wallet()
.default_chain()
.expect("No default chain");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional nit:

Suggested change
.expect("No default chain");
.expect("A default chain should be configured");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants