-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Applications #10
Applications #10
Conversation
f518410
to
104fed3
Compare
679c3ac
to
7c734b2
Compare
This enables us to pass the `--split-linked-modules` flag to `wasm-bindgen`, which we can't do through `wasm-pack`.
7c734b2
to
0b9548e
Compare
0b9548e
to
9f0a839
Compare
9a0b0b4
to
923e9e9
Compare
923e9e9
to
7719d40
Compare
typeof typedObj === "object" || | ||
typeof typedObj === "function") && | ||
typeof typedObj["target"] === "string" && | ||
typedObj["type"] === "get_wallet" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could the type changed to get_wallet_request
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this field should be read as ‘request type’ rather than ‘object type’. So noting that it's a request is redundant. The fact that it's a request, not a response or some other type of event, should always be clear based on the source of the object — this field exists just to distinguish it from other types of request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let committee = result?; | ||
let node_provider = client_context.make_node_provider(); | ||
|
||
let mut validator_versions = HashMap::new(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the HashMap gets serialized into the output, the output could vary from one run to another. So, maybe it is better to use BTreeMap
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's being serialized into a JavaScript object, which anyway doesn't preserve property order — so I don't think it's useful to use a BTreeMap
in this case.
Adds the ability to query application services from Web pages.
linera-protocol
to a version that supports threading on WasmClient
(accessible from the extension itself) andFrontend
(accessible from Web pages) APIs, removing the need for thedapp_
prefix hackFrontend::query_application(&self, application_id: &str, query: &str)
for querying application services