Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vz: trivial changes #1968

Merged
merged 4 commits into from
Oct 30, 2023
Merged

vz: trivial changes #1968

merged 4 commits into from
Oct 30, 2023

Conversation

AkihiroSuda
Copy link
Member

jandubois
jandubois previously approved these changes Oct 30, 2023
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just nit-picking on a single comment

pkg/driver/driver.go Outdated Show resolved Hide resolved
Signed-off-by: Akihiro Suda <[email protected]>
`vz-identifier` will be dependended by PR 1951 for
resolving vmType, so it has to be retained.

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda merged commit de88a43 into lima-vm:master Oct 30, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants