Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ADOPTERS.md #4431

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Introduce ADOPTERS.md #4431

merged 2 commits into from
Nov 7, 2024

Conversation

eriknordmark
Copy link
Contributor

The LF Edge process recommends that there be an ADOPTERS.md for the project. This is an initial version of such a file.

@rene
Copy link
Contributor

rene commented Nov 7, 2024

@eriknordmark , there is one Yetus' complain:

Error: markdownlint:MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]

I think you should remove the last line of the file (blank).

Also, could you please add an entry for this file in the https://github.com/lf-edge/eve/blob/master/docs/mkdocs/mkdocs.yml ?

@eriknordmark
Copy link
Contributor Author

Also, could you please add an entry for this file in the https://github.com/lf-edge/eve/blob/master/docs/mkdocs/mkdocs.yml ?

@rene We don't currently list any of the project markdowns (CONTRIBUTING.md, MAINTAINERS.md) nor the README.md at the top directory. Should I create a new category "Project information" and put all of them under that in mkdocs.yml?

@rene
Copy link
Contributor

rene commented Nov 7, 2024

Also, could you please add an entry for this file in the https://github.com/lf-edge/eve/blob/master/docs/mkdocs/mkdocs.yml ?

@rene We don't currently list any of the project markdowns (CONTRIBUTING.md, MAINTAINERS.md) nor the README.md at the top directory. Should I create a new category "Project information" and put all of them under that in mkdocs.yml?

Indeed, yeah, "Project Information" section sounds good to me....

The LF Edge process recommends that there be an ADOPTERS.md for the project.
This is an initial version of such a file.

Signed-off-by: eriknordmark <[email protected]>
Added the existing CONTRIBUTING.md etc plus the new ADOPTERS.md
to mkdocs.

Signed-off-by: eriknordmark <[email protected]>
Copy link
Contributor

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I assume that you spoke with the named companies and got their approval?

@@ -179,7 +179,7 @@ func download(ctx *downloaderContext, trType zedUpload.SyncTransportType,
}
}

var respChan = make(chan *zedUpload.DronaRequest)
var respChan = make(chan *zedUpload.DronaRequest, 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eriknordmark , change probably forgotten from another branch?

@eriknordmark
Copy link
Contributor Author

Looks fine. I assume that you spoke with the named companies and got their approval?

Yes, but indirectly via folks at ZEDEDA.

PeopleFlo
PV Hardware
Rockwell Automation
Top 2 Auto Manufacturer
Copy link
Member

@OhmSpectator OhmSpectator Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christoph-zededa had a valid question about how to maintain this info when the adopter changes its position in the top =)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this different than other neede updates such as company X acquiring company Y, or OSS project X being folded into OSS project Y?

@eriknordmark eriknordmark merged commit be4d235 into lf-edge:master Nov 7, 2024
43 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants