574 swap usernames to full names on comments page #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
diegoalzate
approved these changes
May 28, 2024
camilovegag
added a commit
that referenced
this pull request
May 28, 2024
* Update back button to recieve a fallback route * Create a loader to redirect to cycle id if cycle is open (protect /results) * Add fallback route to cycle back button * 561 redirect to results when cycle closes (#562) * Match nav distribution from desktop on mobile * Redirect to results if cycle is closed * Add refetch of 5 seconds to cycle * Change redirect to navigate * Add toast * Add fallback route to results page back button * Show toast with clock emoji * Update message * Remove emoji * fix joining public groups * 559 change secret to access code at table (#560) * Change secret to access code at group table * Hide input number arrows * Hide spinner at hover * Fix header ui * Remove type number input styles as they dont work as expected * Burning min of 0 and max of 10000 for input fields (funding at the moment) * Burn a 0 to 10000 validation at number input * Update min and max checks * Make public group registration more general (#565) * Fix query key * Update min number input value from 0 to 250 & validation messages (#568) * Fix nav links on mobile (#566) * 569 update secret groups page (#570) * Update copy * Update layout * Update final question constant (#572) * Minor fixes (#573) * Fix long usernames at comments table * sort by lead if votes are equal * sort by id if votes are equal * add sort fallback by id --------- Co-authored-by: Diego Alzate <[email protected]> * 574 swap usernames to full names on comments page (#575) * Change group names to voter affiliations * Update comments response type * Show full name instead of username --------- Co-authored-by: Diego Alzate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #574
This pr also changes group names to voter affiliations