574 swap usernames to full names on comments page (#575)

* Change group names to voter affiliations * Update comments response type * Show full name instead of username
lexicongovernance · May 28, 2024 · fbe26fa · fbe26fa
1 parent f232da7
commit fbe26fa
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/packages/api/src/types/CommentType.ts b/packages/api/src/types/CommentType.ts
@@ -11,7 +11,14 @@ export type GetCommentsRequest = {
   optionId: string;
 };
 
-export type GetCommentsResponse = (Comment & { user?: { id: string; username: string } })[];
+export type GetCommentsResponse = (Comment & {
+  user?: {
+    id: string;
+    username: string;
+    firstName: string;
+    lastName: string;
+  };
+})[];
 
 export type PostCommentRequest = {
   value: string;

diff --git a/packages/berlin/src/components/tables/comment-table/CommentsTable.tsx b/packages/berlin/src/components/tables/comment-table/CommentsTable.tsx
@@ -103,7 +103,9 @@ function CommentsTable({ comment }: CommentsTableProps) {
       <FlexRow>
         <Comment>{comment.value}</Comment>
       </FlexRow>
-      <Author title={`@${comment.user?.username}`}>@{comment.user?.username}</Author>
+      <Author title={`@${comment.user?.username}`}>
+        {comment.user?.firstName} {comment.user?.lastName}
+      </Author>
       <FormattedDate>{formattedDate}</FormattedDate>
       <FlexRow
         $gap="0.5rem"

diff --git a/packages/berlin/src/components/tables/results-table/ResultsTable.tsx b/packages/berlin/src/components/tables/results-table/ResultsTable.tsx
@@ -73,7 +73,7 @@ function ResultsTable({ $expanded, option, onClick }: ResultsTableProps) {
           <Bold>Distinct groups:</Bold> {option.distinctGroups}
         </Body>
         <Body>
-          <Bold>Group names:</Bold> {option.listOfGroupNames.join(', ')}
+          <Bold>Voter affiliations:</Bold> {option.listOfGroupNames.join(', ')}
         </Body>
       </FlexColumn>
     </Card>