-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: skip infoview breaking test on major version bump #459
base: master
Are you sure you want to change the base?
Changes from all commits
9be8d63
0c9d7eb
0293ef6
f8b25dd
4b14d28
215808e
0abdb43
3ca931b
b5d8adf
5505cce
08f5b85
56c6bde
cab7c4e
54faeb2
cb26800
bc94356
367fb4b
bd2978d
7e8a740
3257649
6dd64b8
c87f6ac
14b6d06
d8db183
a59fd7a
6e11f74
e4a0653
1043ba4
7e5cb9c
ca3cb1d
3e8bdb7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
#!/usr/bin/env bash | ||
|
||
PUBLISHED_VERSION="$(npm view @leanprover/infoview-api version --no-workspaces)" | ||
NEW_VERSION="$(sed -n 's/^\s*"version":\s*"\(.*\)",\s*/\1/p' ./package.json)" | ||
PUBLISHED_MAJOR="$(cut -d '.' -f 1 <<< $PUBLISHED_VERSION)" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If the first component of the semantic version is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thouht semantic versioning is usually Major-Minor-Patch. is your scheme ...-Major-Minor, i.e would it be fine to always check the first two terms? Can fix that tomorrow |
||
NEW_MAJOR="$(cut -d '.' -f 1 <<< $NEW_VERSION)" | ||
|
||
if [ $PUBLISHED_MAJOR == $NEW_MAJOR ]; then | ||
tsc -p test/tsconfig.json | ||
else | ||
echo "Skipping breaking.ts test as major version got bumped from $PUBLISHED_MAJOR to $NEW_MAJOR!" | ||
tsc -p test/tsconfig-breaking.json | ||
fi | ||
|
||
# exit if the above command failed | ||
if [ $? -ne 0 ]; then | ||
exit 1 | ||
fi |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"extends": "../tsconfig", | ||
"compilerOptions": { | ||
"rootDir": "../" | ||
}, | ||
"include": ["./**/*", "../src/**/*"], | ||
"exclude": ["./breaking.ts"] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be the
infoview-api
version?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no it's supposed to be
@leanprover/infoview
, my bad!