Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peakfinder: convert exception to printing a warning. Fixes #350 #351

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

peakfinder: convert exception to printing a warning. Fixes #350 #351

wants to merge 5 commits into from

Conversation

arunpersaud
Copy link

Potential fix for #350

markbandstra
markbandstra approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@markbandstra markbandstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@markbandstra
Copy link
Member

Looks like the tests no longer pass because this change results in a PeakFinderError no longer being raised for a particular case. Strangely this error is only seen in the coveralls test, and the error is opaque in the pip_build_tests.

@jvavrek jvavrek assigned jvavrek and arunpersaud and unassigned jvavrek Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markbandstra markbandstra markbandstra approved these changes

Assignees

@arunpersaud arunpersaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arunpersaud @markbandstra @jvavrek