Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peakfinder: convert exception to printing a warning. Fixes #350 #351

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

peakfinder: convert exception to printing a warning. Fixes #350 #351

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
45dc2dd
peakfinder: convert exception to printing a warning
Aug 23, 2022
581fb73
Merge branch 'main' into peak_finder_exception
jvavrek Nov 2, 2022
719dc8c
Merge branch 'main' into peak_finder_exception
markbandstra Nov 2, 2022
b4c41de
Merge branch 'main' into peak_finder_exception
markbandstra Nov 3, 2022
def311c
Merge branch 'main' into peak_finder_exception
jvavrek Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion becquerel/core/peakfinder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,11 @@ def add_peak(self, xpeak):
/ bw**2
)
if d2 >= 0:
raise PeakFinderError("Second derivative must be negative at peak")
warnings.warn(
f"Second derivative must be negative at peakposition {xbin}",
PeakFinderWarning,
)
return
d2 *= -1
fwhm = 2 * np.sqrt(self.snr[xbin] / d2)
# add the peak if it has a similar FWHM to the kernel's FWHM
Expand Down
Loading