Adding more check geometry processings

.ci/test_blocklist_qt6.txt

@@ -39,3 +39,304 @@ test_core_layerdefinition
 # MSSQL requires the MSSQL docker
 PyQgsProviderConnectionMssql
 PyQgsStyleStorageMssql
+
+# To be fixed
+PyQgsAFSProvider
+PyQgsAggregateMappingWidget
+PyQgsAnimatedMarkerSymbolLayer
+PyQgsArcGisRestUtils
+PyQgsPythonProvider
+PyQgsAggregateCalculator
+PyQgsAnnotation
+PyQgsAnnotationLayer
+PyQgsAnnotationLineItem
+PyQgsAnnotationLineTextItem
+PyQgsAnnotationMarkerItem
+PyQgsAnnotationPointTextItem
+PyQgsAnnotationPolygonItem
+PyQgsAttributeForm
+PyQgsAttributeTableModel
+PyQgsAuthenticationSystem
+PyQgsBatchGeocodeAlgorithm
+PyQgsBlendModes
+PyQgsBlockingProcess
+PyQgsBlockingNetworkRequest
+PyQgsBookmarkManager
+PyQgsBookmarkModel
+PyQgsCategorizedSymbolRenderer
+PyQgsCodeEditorPython
+PyQgsCodeEditor
+PyQgsColorRamp
+PyQgsColorRampLegendNode
+PyQgsColorUtils
+PyQgsCombinedStyleModel
+PyQgsCoordinateFormatter
+PyQgsConditionalStyle
+PyQgsConnectionRegistry
+PyQgsXmlUtils
+PyQgsDateTimeEdit
+PyQgsDateTimeStatisticalSummary
+PyQgsDelimitedTextProvider
+PyQgsEditWidgets
+PyQgsElevationProfileCanvas
+PyQgsEmbeddedSymbolRenderer
+PyQgsExifTools
+PyQgsExpression
+PyQgsExpressionBuilderWidget
+PyQgsFeature
+PyQgsFeatureSink
+PyQgsFieldComboBoxTest
+PyQgsFieldFormattersTest
+PyQgsProject
+PyQgsProjectBadLayers
+PyQgsProjectStyleSettings
+PyQgsFeatureIterator
+PyQgsFeatureRequest
+PyQgsFieldDomain
+PyQgsFieldDomainWidget
+PyQgsField
+PyQgsFields
+PyQgsFieldModel
+PyQgsFieldMappingWidget
+PyQgsFloatingWidget
+PyQgsGdalProvider
+PyQgsGeometryGeneratorSymbolLayer
+PyQgsGeometryTest
+PyQgsGpsLogger
+PyQgsGraduatedSymbolRenderer
+PyQgsGroupLayer
+PyQgsHashLineSymbolLayer
+PyQgsHighlight
+PyQgsJsonUtils
+PyQgsLabelObstacleSettings
+PyQgsLabelSettingsWidget
+PyQgsLabelThinningSettings
+PyQgsLayerMetadata
+PyQgsLayerMetadataProviderPython
+PyQgsLayerMetadataProviderOgr
+PyQgsLayerMetadataResultsModel
+PyQgsLayerTree
+PyQgsLayerTreeView
+PyQgsLayoutAtlas
+PyQgsLayoutElevationProfile
+PyQgsLayoutExporter
+PyQgsLayoutFrame
+PyQgsLayoutManagerModel
+PyQgsLayoutPageCollection
+PyQgsLayoutView
+PyQgsLayoutGuide
+PyQgsLayoutHtml
+PyQgsLayoutItem
+PyQgsLayoutItemComboBox
+PyQgsLayoutLabel
+PyQgsLayoutLegend
+PyQgsLayoutMap
+PyQgsLayoutItemMapItemClipPathSettings
+PyQgsLayoutMapGrid
+PyQgsLayoutMapOverview
+PyQgsLayoutMarker
+PyQgsLayoutPage
+PyQgsLayoutPicture
+PyQgsLayoutPolygon
+PyQgsLayoutPolyline
+PyQgsLayoutScaleBar
+PyQgsLayoutShape
+PyQgsLineSymbolLayers
+PyQgsLineburstSymbolLayer
+PyQgsLocator
+PyQgsMapBoxGlStyleConverter
+PyQgsMapLayer
+PyQgsMapLayerComboBox
+PyQgsMapLayerModel
+PyQgsMapLayerUtils
+PyQgsMapRenderer
+PyQgsMarkerLineSymbolLayer
+PyQgsMetadataBase
+PyQgsMemoryProvider
+PyQgsMeshLayerProfileGenerator
+PyQgsNetworkAccessManager
+PyQgsNullSymbolRenderer
+PyQgsNewGeoPackageLayerDialog
+PyQgsNewVectorTableDialog
+PyQgsOgcUtils
+PyQgsOGRProviderGpkg
+PyQgsOGRProviderSqlite
+PyQgsPalLabelingBase
+PyQgsPalLabelingCanvas
+PyQgsPalLabelingLayout
+PyQgsPalLabelingPlacement
+PyQgsPlot
+PyQgsPointCloudAttributeComboBox
+PyQgsPointCloudAttributeModel
+PyQgsPointCloudClassifiedRenderer
+PyQgsPointCloudLayerProfileGenerator
+PyQgsPointCloudRgbRenderer
+PyQgsPointDisplacementRenderer
+PyQgsProcessExecutablePt1
+PyQgsProcessExecutablePt2
+PyQgsProcessingInPlace
+PyQgsProcessingAlgRunner
+PyQgsProcessingParameters
+PyQgsProcessingPackageLayersAlgorithm
+PyQgsProjectMetadata
+PyQgsProjectUtils
+PyQgsProviderConnectionModel
+PyQgsProviderConnectionGpkg
+PyQgsProviderConnectionSpatialite
+PyQgsSensorManager
+PyQgsSensorModel
+PyQgsStyleStorageSpatialite
+PyQgsStyleStorageGpkg
+PyQgsProviderSublayerDetails
+PyQgsProviderSublayerModel
+PyQgsRangeSlider
+PyQgsRangeWidgets
+PyQgsRasterAttributeTable
+PyQgsRasterAttributeTableModel
+PyQgsRasterFileWriter
+PyQgsRasterLayer
+PyQgsRasterLayerProfileGenerator
+PyQgsRasterLayerRenderer
+PyQgsRasterLineSymbolLayer
+PyQgsRasterPipe
+PyQgsRasterTransparencyWidget
+PyQgsProviderUtils
+PyQgsRenderContext
+PyQgsRubberBand
+PyQgsSingleSymbolRenderer
+PyQgsShapefileProvider
+PyQgsSvgCache
+PyQgsTabfileProvider
+PyQgsTextRenderer
+PyQgsOGRProvider
+PyQgsShortcutsManager
+PyQgsSimpleLineSymbolLayer
+PyQgsSingleItemModel
+PyQgsSpatialiteProvider
+PyQgsSymbolLayer
+PyQgsRasterRendererCreateSld
+PyQgsSymbolLayerCreateSld
+PyQgsSymbolLayerReadSld
+PyQgsArrowSymbolLayer
+PyQgsSymbolExpressionVariables
+PyQgsStringUtils
+PyQgsStyleModel
+PyQgsSubsetStringEditorProviderRegistry
+PyQgsSymbolLayerUtils
+PyQgsTemporalUtils
+PyQgsTextDocument
+PyQgsTextFormatWidget
+PyQgsTreeWidgetItem
+PyQgsUnitTypes
+PyQgsValidityChecks
+PyQgsValidityResultsWidget
+PyQgsVectorFieldMarkerSymbolLayer
+PyQgsVectorFileWriter
+PyQgsVectorLayer
+PyQgsVectorLayerElevationProperties
+PyQgsVectorLayerFeatureCounter
+PyQgsVectorLayerCache
+PyQgsVectorLayerEditBuffer
+PyQgsVectorLayerEditUtils
+PyQgsVectorLayerProfileGenerator
+PyQgsVectorLayerSelectedFeatureSource
+PyQgsVectorLayerShapefile
+PyQgsVectorLayerTemporalProperties
+PyQgsVectorLayerUtils
+PyQgsZonalStatistics
+PyQgsVirtualLayerProvider
+PyQgsVirtualLayerDefinition
+PyQgsLayerDefinition
+PyQgsWFSProvider
+PyQgsOapifProvider
+PyQgsConsole
+PyQgsDBManagerGpkg
+PyQgsDBManagerSpatialite
+PyQgsFileDownloader
+PyQgsSettings
+PyQgsSettingsEntry
+PyQgsSettingsTreeNode
+PyQgsAuxiliaryStorage
+PyQgsFieldValidator
+PyQgsDBManagerSQLWindow
+PyQgsSelectiveMasking
+PyQgsRasterAttributeTableWidget
+PyQgsServerWMS
+PyQgsServerApi
+PyQgsServerWMSGetFeatureInfo
+PyQgsServerWMSGetMap
+PyQgsServerWMSGetLegendGraphic
+PyQgsServerWMSGetPrint
+PyQgsServerWMSGetPrintExtra
+PyQgsServerWMSGetPrintOutputs
+PyQgsServerWMSGetPrintAtlas
+PyQgsServerWMSDimension
+PyQgsServerSettings
+PyQgsServerAccessControlWMSGetlegendgraphic
+PyQgsServerAccessControlWFSTransactional
+PyQgsServerCacheManager
+PyQgsServerWFS
+PyQgsServerWFST
+PyQgsServerLocaleOverride
+PyQgsAuthManagerPasswordOWSTest
+PyQgsServerServices
+PyQgsArcGisPortalUtils
+PyQgsBinaryWidget
+PyQgsClassificationMethod
+PyQgsGeocoderLocatorFilter
+PyQgsNominatimGeocoder
+PyQgsGoogleMapsGeocoder
+PyQgsGpxProvider
+PyQgsHistoryProviderRegistry
+PyQgsLegendPatchShape
+PyQgsMapCanvas
+PyQgsMapCanvasAnnotationItem
+PyQgsMergedFeatureRenderer
+PyQgsMeshLayerElevationProperties
+PyQgsNumericFormat
+PyQgsPointCloudDataProvider
+PyQgsPointCloudExtentRenderer
+PyQgsPointClusterRenderer
+PyQgsTableCell
+PyQgsSearchWidgetWrapper
+PyQgsSimpleFillSymbolLayer
+PyQgsSymbol
+PyQgsTiles
+PyQgsRelationEditorWidgetRegistry
+PyQgsVectorTile
+PyQgsVtpk
+ProcessingGeneralTest
+ProcessingGuiTest
+ProcessingModelerTest
+ProcessingProjectProviderTest
+ProcessingParametersTest
+ProcessingGenericAlgorithmsTest
+ProcessingQgisAlgorithmsTestPt1
+ProcessingQgisAlgorithmsTestPt2
+ProcessingQgisAlgorithmsTestPt3
+ProcessingQgisAlgorithmsTestPt4
+ProcessingQgisAlgorithmsTestPt5
+ProcessingGdalAlgorithmsGeneralTest
+ProcessingGdalAlgorithmsRasterTest
+ProcessingGdalAlgorithmsVectorTest
+ProcessingCheckValidityAlgorithmTest
+ProcessingGrass7AlgorithmsImageryTest
+ProcessingGrass7AlgorithmsRasterTestPt1
+ProcessingGrass7AlgorithmsRasterTestPt2
+ProcessingGrass7AlgorithmsVectorTest
+ProcessingOtbAlgorithmsTest
+PyCoreAdditions
+PyPythonRepr
+TestQgsRandomMarkerSymbolLayer
+ProcessingToolsTest
+test_app_qgisapppython
+PyQgsCesium3dTilesLayer
+PyQgsCoordinateReferenceSystemModel
+PyQgsFilledLineSymbolLayer
+PyQgsPainting
+PyQgsProviderRegistry
+PyQgsTiledSceneLayer
+PyQgsTiledSceneTile
+ProcessingScriptUtilsTest
+PyQgsColorScheme
+PyQgsSearchWidgetToolButton

.clang-tidy

@@ -0,0 +1 @@
+Checks: 'bugprone-*,-bugprone-easily-swappable-parameters,-bugprone-virtual-near-miss'

.docker/docker-qgis-build.sh

@@ -85,7 +85,7 @@ cmake \
  -DWITH_STAGED_PLUGINS=ON \
  -DWITH_GRASS7=${WITH_GRASS7} \
  -DWITH_GRASS8=${WITH_GRASS8} \
- -DWITH_GRASS_PLUGIN=${WITH_QT5} \
+ -DWITH_GRASS_PLUGIN=${WITH_GRASS8} \
  -DSUPPRESS_QT_WARNINGS=ON \
  -DENABLE_TESTS=ON \
  -DENABLE_MODELTEST=${WITH_QT5} \
@@ -101,13 +101,14 @@ cmake \
  -DWITH_QWTPOLAR=OFF \
  -DWITH_APIDOC=OFF \
  -DWITH_ASTYLE=OFF \
- -DWITH_BINDINGS=${WITH_QT5} \
+ -DWITH_BINDINGS=ON \
  -DWITH_SERVER=ON \
  -DWITH_SERVER_LANDINGPAGE_WEBAPP=${WITH_QT5} \
  -DWITH_ORACLE=ON \
  -DWITH_PDAL=ON \
  -DWITH_QTSERIALPORT=ON \
  -DWITH_QTWEBKIT=${WITH_QT5} \
+ -DWITH_QTWEBENGINE=${WITH_QTWEBENGINE} \
  -DWITH_OAUTH2_PLUGIN=${WITH_QT5} \
  -DORACLE_INCLUDEDIR=/instantclient_19_9/sdk/include/ \
  -DORACLE_LIBDIR=/instantclient_19_9/ \

.docker/docker-qgis-clangtidy.sh

@@ -35,12 +35,11 @@ curl -XGET https://raw.githubusercontent.com/llvm/llvm-project/llvmorg-14.0.6/cl
 echo "::endgroup::"
 
 echo "${bold}Run clang-tidy on modifications...${endbold}"
-CLANG_TIDY_CHECKS=$(cat tests/code_layout/clangtidy_checks.txt | grep -ve "^#" | grep -ve "^$" | tr -d '\n')
 
 # We need to add build/src/test dir as extra include directories because when clang-tidy tries to process qgstest.h
 # it has no compile_commands.json instructions to know what are include directories
 # It manages to figure out for other headers though, I don't get how...
-git diff -U0 HEAD^ | python3 clang-tidy-diff.py -p1 -path=${CTEST_BUILD_DIR} -use-color -checks="$CLANG_TIDY_CHECKS" -extra-arg=-I${CTEST_BUILD_DIR}/src/test/ | tee clang-tidy.log
+git diff -U0 HEAD^ | python3 clang-tidy-diff.py -p1 -path=${CTEST_BUILD_DIR} -use-color -extra-arg=-I${CTEST_BUILD_DIR}/src/test/ | tee clang-tidy.log
 
 echo -e "\e[1;34mTo reproduce locally:"
 echo -e "\e[1;34m - launch cmake with option -DCMAKE_EXPORT_COMPILE_COMMANDS=ON"

.docker/qgis3-qt6-build-deps.dockerfile

@@ -1,6 +1,6 @@
 ARG DISTRO_VERSION=38
 
-FROM fedora:${DISTRO_VERSION} as single
+FROM fedora:${DISTRO_VERSION} as binary-for-oracle
 MAINTAINER Matthias Kuhn <[email protected]>
 
 RUN dnf -y --refresh install \
@@ -32,11 +32,17 @@ RUN dnf -y --refresh install \
     PDAL \
     PDAL-libs \
     PDAL-devel \
+    perl-YAML-Tiny \
     proj-devel \
     protobuf-devel \
     protobuf-lite-devel \
     python3-devel \
+    python3-pyqt6 \
+    python3-pyqt6-devel \
+    python3-qscintilla-qt6 \
+    python3-qscintilla-qt6-devel \
     python3-termcolor \
+    PyQt-builder \
     qca-qt6-devel \
     qt6-qt3d-devel \
     qt6-qtbase-devel \
@@ -49,9 +55,11 @@ RUN dnf -y --refresh install \
     qt6-qtdeclarative-devel \
     qt6-qt5compat-devel \
     qt6-qtmultimedia-devel \
+    qt6-qtwebengine-devel \
     qtkeychain-qt6-devel \
     qwt-qt6-devel \
     qscintilla-qt6-devel \
+    sip6 \
     spatialindex-devel \
     sqlite-devel \
     unzip \
@@ -82,3 +90,14 @@ RUN unzip instantclient-sqlplus-linux.x64-19.9.0.0.0dbru.zip
 
 ENV PATH="/instantclient_19_9:${PATH}"
 ENV LD_LIBRARY_PATH="/instantclient_19_9:${LD_LIBRARY_PATH}"
+ENV LANG=C.UTF-8
+
+FROM binary-for-oracle as binary-only
+
+RUN dnf -y --refresh install \
+    python3-gdal \
+    python3-nose2 \
+    python3-psycopg2 \
+    python3-pyyaml
+
+FROM binary-only