Reformat and rename simulation engine functions #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patkenneally
force-pushed
the
refactor/rename-update-reset-functions
branch
from
2555bb4
to
0ebd248
Compare
codyallard28
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors or renames many simulation core functions. The first series of renaming are simple formatting updates to change function names to lower camel case. The second half of the PR renames a number of functions to remove redundancy (e.g. change
disableTasktodisablebecause the function is a member of the Task class already), or clarify a function.Verification
All tests run locally in debug build profile and in CI in the release build profile.
Documentation
Find and replace was done on the documentation.
Future work
None