Data Product Copier #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinkelk
commented
Jun 10, 2024
src/components/product_copier/product_copier_error_info.record.yaml
Outdated
Show resolved
Hide resolved
dinkelk
commented
Jun 14, 2024
src/components/product_copier/component-product_copier-implementation.adb
Outdated
Show resolved
Hide resolved
src/components/product_copier/component-product_copier-implementation.adb
Outdated
Show resolved
Hide resolved
src/components/product_copier/component-product_copier-implementation.adb
Show resolved
Hide resolved
src/components/product_copier/component-product_copier-implementation.adb
Outdated
Show resolved
Hide resolved
|
I remade the git history from scratch if that's alright. I basically committed each file in an order that allows it to always compile, but this completely overwrote history -- let me know if I should undo that. |
Yeah this is good. Telling a story for the reviewer is the primary goal with the history. |
|
One more doubt as I review this again -- should the copier be able to be hooked up to multiple Send connectors? So given a source, wouldn't it make sense to be able to copy to multiple destinations? |
MyApaulogies
force-pushed
the
dp-copier
branch
2 times, most recently
from
305e74a
to
005ab30
Compare
dinkelk
commented
Jun 18, 2024
src/components/product_copier/component-product_copier-implementation.adb
Outdated
Show resolved
Hide resolved
src/components/product_copier/component-product_copier-implementation.ads
Outdated
Show resolved
Hide resolved
dinkelk
commented
Jun 18, 2024
MyApaulogies
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component to copy data products from one database to another. This can be used to "freeze" as set of data products to obtain a consistent set for something like a control cycle.