feat: add Neo4j Cypher Search #2741
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
auto:enhancement
![dosubot[bot]](https://avatars.githubusercontent.com/in/324583?s=60&v=4){kind=small}
langchain/package.json
Outdated
| @@ -1121,6 +1121,7 @@ | |||
| "langchainhub": "~0.0.6", | |||
There was a problem hiding this comment.
Great work on the PR! I noticed that this change adds a new hard dependency ("node-llama-cpp"). This comment is just to flag the change for maintainers to review.
| @@ -0,0 +1,40 @@ | |||
| /* eslint-disable no-process-env */ | |||
There was a problem hiding this comment.
This comment is flagging the addition of code that accesses environment variables via process.env in the cypher.test.ts file. Maintainers should review this change to ensure proper handling and usage of environment variables.
There was a problem hiding this comment.
What needs to be done to resolve this issue?
| @@ -0,0 +1,21 @@ | |||
| /* eslint-disable no-process-env */ | |||
There was a problem hiding this comment.
Great work on adding the test case for initializing and connecting to the Neo4j database! This comment is just flagging the use of environment variables via process.env for maintainers to review.
| await graph.query("MATCH (n) DETACH DELETE n"); | ||
|
|
||
| // Create two nodes and a relationship | ||
| await graph.query( |
There was a problem hiding this comment.
await graph.query(
"CREATE (a:Actor {name:'Bruce Willis'})" +
"-[:ACTED_IN {role: "Butch Coolidge"}]->(:Movie {title: 'Pulp Fiction'})"
);
Then the output would be Bruce Willis played Butch Coolidge in Pulp Fiction.
There was a problem hiding this comment.
@oskarhane had a bunch of problems retrieving the role of a an actor in a movie, so I wouldn't add that to the test since it would be more a test of an LLM than the implementation
| @@ -0,0 +1,40 @@ | |||
| /* eslint-disable no-process-env */ | |||
There was a problem hiding this comment.
What needs to be done to resolve this issue?
easwee
changed the title
|
LGTM |
|
Looks great (and am happy to merge) but we should add some docs with setup and usage instructions under |
| returnDirect?: boolean; | ||
| } | ||
|
|
||
| export class GraphCypherQAChain extends BaseChain { |
There was a problem hiding this comment.
Would be nice to show this in expression language as well at some point if possible!
|
CI is failing - maybe because it's relying on an env var being set? Can we swap it out with a dummy value? |
|
Thank you! |
Porting Neo4j and GraphCypherQAChain from LangChain Python.