Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Add Graph store and Graph QA #2514

Closed
wants to merge 2 commits into from

Conversation

gkorland
Copy link

@gkorland gkorland commented Sep 5, 2023

An initial PR just to see that I'm building the right API.
Fixes #2383

@vercel
Copy link

vercel bot commented Sep 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Sep 27, 2023 10:48am

@dosubot dosubot bot added the auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features label Sep 5, 2023
@jacoblee93
Copy link
Collaborator

Will have a look at this tomorrow! Apologies for the delay.

@gkorland
Copy link
Author

@jacoblee93 no worries, I really didn't do too much, just did a very early PR to get your feedback and make sure I'm going in the right direction before I put more time.

@jacoblee93
Copy link
Collaborator

jacoblee93 commented Sep 19, 2023

Hey @gkorland really sorry for the delay - had a chat with @baskaryan and I don't think we have a clear idea of the right common interface between graph stores at the moment - would you be up for implementing it like you did in Python or extending a very minimal base class?

I think adding some asRetriever() wrapper can make Falkor and other GraphDBs interact usefully with other LangChain constructs.

@gkorland
Copy link
Author

@gkorland
Copy link
Author

gkorland commented Oct 3, 2023

@jacoblee93 I noticed the PRs #2741 #2749 were merged so I guess there is no need for this PR, I'll submit a new PR based on these PRs

@gkorland gkorland closed this Oct 3, 2023
@gkorland gkorland deleted the graph_store branch October 3, 2023 07:16
@gkorland
Copy link
Author

gkorland commented Oct 3, 2023

@jacoblee93 see #2774

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] Graph DB QA chain for JS
2 participants