Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add custom telemetry context upon client creation #31

Merged
merged 20 commits into from
Mar 15, 2024

Conversation

holtskinner
Copy link
Collaborator

Tested locally successfully when installing from source PR.

DO NOT MERGE - Until googleapis/python-aiplatform#3261 is Released and minimum_expected_version is updated to correct version.

- **Description:** Add custom user agent to Vertex AI SDK initialization. Allows API usage metrics collection.
  - Follow-up to langchain-ai/langchain#12168
- **Dependencies:** `google-cloud-aiplatform` to be updated in PR googleapis/python-aiplatform#3261
  - Before Merging, Update `raise_vertex_import_error(minimum_expected_version: str = "1.38.0")` to the actual version once the SDK is updated.
  - https://pypi.org/project/google-cloud-aiplatform/

Tested locally successfully when installing from source PR.

DO NOT MERGE - Until googleapis/python-aiplatform#3261 is Released and `minimum_expected_version` is updated to correct version.
@holtskinner holtskinner requested a review from lkuligin February 26, 2024 19:03
@lkuligin lkuligin marked this pull request as draft February 26, 2024 19:11
@lkuligin lkuligin marked this pull request as ready for review March 14, 2024 19:57
@holtskinner
Copy link
Collaborator Author

Blocked by googleapis/python-aiplatform#3445

google-cloud-aiplatform v1.44.0 needs to be released before this PR can go through

@lkuligin lkuligin merged commit 5ad6963 into main Mar 15, 2024
13 checks passed
@lkuligin lkuligin deleted the vertexai-clientinfo branch March 15, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants