partner(google-vertex-ai): Add Custom User Agent to Vertex AI SDK #17043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For API metrics collection - Followup to langchain-ai#12168 NOTE: Before Merging, Update `raise_vertex_import_error(minimum_expected_version: str = "1.40.0")` to the actual version once the SDK is updated. - https://pypi.org/project/google-cloud-aiplatform/
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: embeddings
- TODO: Undo this change
- Reverted minimum version
holtskinner
force-pushed
the
vertex-ai-useragent
branch
from
63c91e5 to
5fa033f
Compare
- Remove try/except from community vertexai.py
…lt version of `0.0.0` in case of failure. - This is needed for internal queries to work as expected.
holtskinner
changed the title
|
cc @lkuligin |
lkuligin
approved these changes
Feb 6, 2024
efriis
reviewed
Feb 10, 2024
| @@ -80,6 +94,9 @@ def init_vertexai( | |||
| credentials=credentials, | |||
| ) | |||
|
|
|||
| _, user_agent = _get_user_agent(module) | |||
| initializer.global_config.append_user_agent(user_agent) | |||
There was a problem hiding this comment.
getting mypy errors that this append_user_agent function doesn't exist on _Config. Also causes the tests to fail, so seems like a real problem even after updating packages.
@holtskinner @lkuligin let me know how's best to fix!
There was a problem hiding this comment.
Oh I'm silly - looks like it'll be in 42 when ready. Will convert this to a draft PR for now!
|
@lkuligin not sure if this one made it over to https://github.com/langchain-ai/langchain-google yet - should this be re-opened over there? |
|
I think that langchain-ai/langchain-google#31 covers everything |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
google-cloud-aiplatformto be updated in PR feat: Add custom tool context manager for telemetry googleapis/python-aiplatform#3261raise_vertex_import_error(minimum_expected_version: str = "1.38.0")to the actual version once the SDK is updated.Tested locally successfully when installing from source PR.
DO NOT MERGE - Until googleapis/python-aiplatform#3261 is Released and
minimum_expected_versionis updated to correct version.