Convert old CLI standalone commands to laminas-cli commands #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
This avoids us to mock method return values due to the lack of native return types. Signed-off-by: Maximilian Bösing <[email protected]>
…ting file path Signed-off-by: Maximilian Bösing <[email protected]>
boesing
force-pushed
the
qa/laminas-cli-commands
branch
from
7efd5e7 to
0fe2d78
Compare
Ocramius
reviewed
Feb 22, 2023
…sumed This also marks the existing CLI commands as internal as these are not meant to be instantiated from any project. Signed-off-by: Maximilian Bösing <[email protected]>
boesing
force-pushed
the
qa/laminas-cli-commands
branch
from
771bbcb to
7bd2668
Compare
Xerkus
requested changes
Apr 2, 2023
…atic There can be too many side-effects, i.e. by having cached configs, etc. and thus, we decided to drop this. Signed-off-by: Maximilian Bösing <[email protected]>
This was referenced Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This converts the existing CLI commands to symfony commands which can be used with
laminas-cli.These should get automatically registered to upstream projects once
symfony/consoleis available.