-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created tool to inject factory maps into configuration #21
Comments
@GeeH I think this completes the pieces we need for the 3.2 release; can you review? Originally posted by @weierophinney at zendframework/zend-servicemanager#161 (comment) |
ping @GeeH would be great to have this can you review? just a reminder in case you forgot :) Originally posted by @svycka at zendframework/zend-servicemanager#161 (comment) |
I spoke to @weierophinney in person which is naughty and I should have commented on here. @weierophinney I suggest we release 3.2 as it is and make further improvements in this area for 3.3. Originally posted by @GeeH at zendframework/zend-servicemanager#161 (comment) |
Moved target milestone to Originally posted by @Ocramius at zendframework/zend-servicemanager#161 (comment) |
@weierophinney I forget what the hell we did here; do we want to release this as part of the 3.5 release I'm working towards? |
Closing here as the PR was never re-opened and I do not want to dive too deep into this as of now. If this is still a feature we want to ship at some point, feel free to re-open the PR on top of #176 |
This patch adds a new tool,
create-factory-map
, which will map a given class to a given factory in the specified configuration file, under the provided configuration key (defaulting toservice_manager
).As part of this work, I moved the methods for dumping configuration files into a trait; this trait is now composed by both the
ConfigDumper
andFactoryMapperCommand
.Originally posted by @weierophinney at zendframework/zend-servicemanager#161
The text was updated successfully, but these errors were encountered: