Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created tool to inject factory maps into configuration #21

Closed
weierophinney opened this issue Dec 31, 2019 · 6 comments
Closed

Created tool to inject factory maps into configuration #21

weierophinney opened this issue Dec 31, 2019 · 6 comments

Comments

@weierophinney
Copy link
Member

This patch adds a new tool, create-factory-map, which will map a given class to a given factory in the specified configuration file, under the provided configuration key (defaulting to service_manager).

Usage:

  ./vendor/zendframework/zend-servicemanager/bin/create-factory-map [-h|--help|help] <configFile> <className> <factoryName> [<key>]

Arguments:

  -h|--help|help    This usage message
  <configFile>      Path to an config file in which to map the factory.
                    If the file does not exist, it will be created. If
                    it does exist, it must return an array.
  <className>       Name of the class to map to a factory.
  <factoryName>     Name of the factory class to use with <className>.
  [<key>]           (Optional) The top-level configuration key under which
                    the factory map should appear; defaults to
                    "service_manager".

As part of this work, I moved the methods for dumping configuration files into a trait; this trait is now composed by both the ConfigDumper and FactoryMapperCommand.


Originally posted by @weierophinney at zendframework/zend-servicemanager#161

@weierophinney
Copy link
Member Author

@GeeH I think this completes the pieces we need for the 3.2 release; can you review?


Originally posted by @weierophinney at zendframework/zend-servicemanager#161 (comment)

@weierophinney
Copy link
Member Author

ping @GeeH would be great to have this can you review? just a reminder in case you forgot :)


Originally posted by @svycka at zendframework/zend-servicemanager#161 (comment)

@weierophinney
Copy link
Member Author

I spoke to @weierophinney in person which is naughty and I should have commented on here. @weierophinney I suggest we release 3.2 as it is and make further improvements in this area for 3.3.


Originally posted by @GeeH at zendframework/zend-servicemanager#161 (comment)

@weierophinney
Copy link
Member Author

Moved target milestone to 3.4.0


Originally posted by @Ocramius at zendframework/zend-servicemanager#161 (comment)

@GeeH
Copy link
Contributor

GeeH commented Jun 8, 2020

@weierophinney I forget what the hell we did here; do we want to release this as part of the 3.5 release I'm working towards?

@boesing
Copy link
Member

boesing commented Mar 5, 2023

Closing here as the PR was never re-opened and I do not want to dive too deep into this as of now. If this is still a feature we want to ship at some point, feel free to re-open the PR on top of #176

@boesing boesing closed this as completed Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants