Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update controller-runtime to v0.16.3, and other packages to latest versions #795

Merged
merged 15 commits into from
Dec 22, 2023

Conversation

jcanocan
Copy link
Contributor

@jcanocan jcanocan commented Dec 22, 2023

What this PR does / why we need it:
Updated:

  • Golang version to 1.20.
  • github.com/openshift/* modules to branch release-4.15.
  • github.com/prometheus/* modules to latest versions.
  • github.com/tektoncd/pipeline to v0.54.0.
  • k8s.io/* modules to v0.28.3.
  • kubevirt.io/api to v1.1.0.
  • kubevirt.io/containerized-data-importer-api to v1.58.0.
  • sigs.k8s.io/controller-runtime to v0.16.3.
  • sigs.k8s.io/kustomize/* modules to latest versions.

Which issue(s) this PR fixes:
Fixes # #597
Overtakes # #745

None

The URL vbom.ml/util does not exist.
Replacing it with github URL.

Signed-off-by: Andrej Krejcir <[email protected]>
Updated required golang version to 1.20 for
both packages.

Signed-off-by: Andrej Krejcir <[email protected]>
Change go.mod file and download vendored dependencies.

This is the first commit in a series that will address
breaking changes.

THIS COMMIT DOES NOT COMPILE

Signed-off-by: Andrej Krejcir <[email protected]>
This commit does basic changes so that "make vet" passes.
The resulting code is still not correct.

Signed-off-by: Andrej Krejcir <[email protected]>
These are needed, because injection interfaces were removed.

Signed-off-by: Andrej Krejcir <[email protected]>
Signed-off-by: Andrej Krejcir <[email protected]>
Regenerated CRDs using "make container-build".

Signed-off-by: Andrej Krejcir <[email protected]>
Updated:
- github.com/openshift modules release-4.15 branch
- k8s.io modules to v0.28.2
- sigs.k8s.io/kustomize modules to v0.15.0

Signed-off-by: Andrej Krejcir <[email protected]>
The "k8s.io/utils/pointer" packege is deprecated,
using "k8s.io/utils/ptr" instead.

Signed-off-by: Andrej Krejcir <[email protected]>
Added more context for errors in logs.

Signed-off-by: Andrej Krejcir <[email protected]>
The previous imported version was incorrect.

Signed-off-by: Andrej Krejcir <[email protected]>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 22, 2023
Copy link

/cc sradco

@kubevirt-bot kubevirt-bot requested a review from sradco December 22, 2023 10:41
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
No data about Coverage
0.9% Duplication on New Code

See analysis details on SonarCloud

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 22, 2023
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2023
@kubevirt-bot kubevirt-bot merged commit 8e29d4e into kubevirt:main Dec 22, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants