Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Update controller-runtime to v0.16.3, and other packages to latest versions #745

Closed
wants to merge 15 commits into from
Closed

deps: Update controller-runtime to v0.16.3, and other packages to latest versions #745

wants to merge 15 commits into from

Conversation

akrejcir
Copy link
Collaborator

What this PR does / why we need it:
Updated:

  • Golang version to 1.20.
  • github.com/openshift/* modules to branch release-4.15.
  • github.com/prometheus/* modules to latest versions.
  • github.com/tektoncd/pipeline to v0.54.0.
  • k8s.io/* modules to v0.28.3.
  • kubevirt.io/api to v1.1.0.
  • kubevirt.io/containerized-data-importer-api to v1.58.0.
  • sigs.k8s.io/controller-runtime to v0.16.3.
  • sigs.k8s.io/kustomize/* modules to latest versions.

Which issue(s) this PR fixes:
Fixes # #597

Release note:

None

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 30, 2023
@github-actions GitHub Actions
Copy link

/cc sradco

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

/cc sradco

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

/cc sradco

@akrejcir akrejcir mentioned this pull request Dec 1, 2023
Closed
@akrejcir akrejcir marked this pull request as draft December 1, 2023 10:44
@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2023
@akrejcir
Copy link
Collaborator Author

akrejcir commented Dec 1, 2023

/test ci/prow/unittests

@kubevirt-bot
Copy link
Contributor

@akrejcir: No presubmit jobs available for kubevirt/ssp-operator@main

In response to this:

/test ci/prow/unittests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 1, 2023

@akrejcir: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-functests
  • /test e2e-single-node-functests
  • /test e2e-upgrade-functests
  • /test images
  • /test unittests
  • /test win10-pipeline-example-test
  • /test win11-pipeline-example-test
  • /test win2k22-pipeline-example-test

Use /test all to run all jobs.

In response to this:

/test ci/prow/unittests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akrejcir
Copy link
Collaborator Author

akrejcir commented Dec 1, 2023

/test unittests

@kubevirt-bot
Copy link
Contributor

@akrejcir: No presubmit jobs available for kubevirt/ssp-operator@main

In response to this:

/test unittests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

/cc sradco

@akrejcir
Copy link
Collaborator Author

akrejcir commented Dec 1, 2023

/test unittests

@kubevirt-bot
Copy link
Contributor

@akrejcir: No presubmit jobs available for kubevirt/ssp-operator@main

In response to this:

/test unittests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akrejcir
Copy link
Collaborator Author

akrejcir commented Dec 1, 2023

/test e2e-functests

@kubevirt-bot
Copy link
Contributor

@akrejcir: No presubmit jobs available for kubevirt/ssp-operator@main

In response to this:

/test e2e-functests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

/cc sradco

@akrejcir
Copy link
Collaborator Author

akrejcir commented Dec 5, 2023

/test e2e-functests

@kubevirt-bot
Copy link
Contributor

@akrejcir: No presubmit jobs available for kubevirt/ssp-operator@main

In response to this:

/test e2e-functests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

/cc sradco

@akrejcir akrejcir mentioned this pull request Dec 5, 2023
Merged
jcanocan
jcanocan reviewed Dec 11, 2023
View reviewed changes
Copy link
Contributor

@jcanocan jcanocan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @akrejcir !

tests/tests_suite_test.go Show resolved Hide resolved
tests/tests_suite_test.go Show resolved Hide resolved
0xFelix
0xFelix reviewed Dec 11, 2023
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2023
@0xFelix
Copy link
Member

0xFelix commented Dec 11, 2023

/retest

@akrejcir
fix: Import correct apiextensions version
222fac2 
The previous imported version was incorrect.

Signed-off-by: Andrej Krejcir <[email protected]>
@github-actions GitHub Actions
Copy link

/cc sradco

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@akrejcir
Copy link
Collaborator Author

/retest

2 similar comments
@akrejcir
Copy link
Collaborator Author

/retest

@akrejcir
Copy link
Collaborator Author

/retest

@akrejcir
Copy link
Collaborator Author

The functional tests pass locally.

@jcanocan
Copy link
Contributor

/retest

4 similar comments
@jcanocan
Copy link
Contributor

/retest

@0xFelix
Copy link
Member

0xFelix commented Dec 21, 2023

/retest

@0xFelix
Copy link
Member

0xFelix commented Dec 21, 2023

/retest

@0xFelix
Copy link
Member

0xFelix commented Dec 21, 2023

/retest

@0xFelix
Copy link
Member

0xFelix commented Dec 21, 2023

/retest-required

@0xFelix
Copy link
Member

0xFelix commented Dec 21, 2023

/retest

4 similar comments
@0xFelix
Copy link
Member

0xFelix commented Dec 21, 2023

/retest

@0xFelix
Copy link
Member

0xFelix commented Dec 21, 2023

/retest

@0xFelix
Copy link
Member

0xFelix commented Dec 21, 2023

/retest

@0xFelix
Copy link
Member

0xFelix commented Dec 22, 2023

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 22, 2023

@akrejcir: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-upgrade-functests 222fac2 link true /test e2e-upgrade-functests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcanocan jcanocan mentioned this pull request Dec 22, 2023
Merged
@jcanocan
Copy link
Contributor

Recreated this PR since it requires this change #792 to pass CI. Without it, it CI won't work. Hope you don't mind @akrejcir.

@0xFelix
Copy link
Member

0xFelix commented Dec 22, 2023

Superseded by #795

@0xFelix 0xFelix closed this Dec 22, 2023
@akrejcir akrejcir deleted the update-cr branch January 2, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcanocan jcanocan jcanocan left review comments

@0xFelix 0xFelix 0xFelix left review comments

@sradco sradco Awaiting requested review from sradco

@codingben codingben Awaiting requested review from codingben

@ksimon1 ksimon1 Awaiting requested review from ksimon1

@lyarwood lyarwood Awaiting requested review from lyarwood

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akrejcir @kubevirt-bot @0xFelix @jcanocan