Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of deprecated .spec.running field #48

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove usage of deprecated .spec.running field #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kubevirt-101/step2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ kubectl get vms
```{{execute}}

```
kubectl get vms -o yaml testvm | grep -E 'running:.*|$'
kubectl get vms -o yaml testvm | grep -E 'runStrategy:.*|$'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the default runStrategy set to effectively be the same as stopped? i.e. if none is specified, does the student still need to verify they are stopped and use virtctl to start them?

Copy link
Author

@RamLavi RamLavi Dec 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running: true equals runStrategy: Always
and running: false equals runStrategy: Halted
no need to check virtctl.

```{{execute}}

Notice from the output that the VM is not running yet.
Expand Down
2 changes: 1 addition & 1 deletion kubevirt-cdi/step2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ metadata:
kubevirt.io/os: linux
name: vm1
spec:
running: true
runStrategy: Always
template:
metadata:
creationTimestamp: null
Expand Down