Remove usage of deprecated .spec.running field #48
Conversation
kubevirt-bot
added
the
dco-signoff: yes
The .spec.running field is deprecated, therefore we should runStrategy instead. For more info, look at: kubevirt/kubevirt#11993i Signed-off-by: Ram Lavi <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
RamLavi
force-pushed
the
remove_running_api
branch
from
b1b93ec to
37a08b9
Compare
| @@ -15,7 +15,7 @@ kubectl get vms | |||
| ```{{execute}} | |||
|
|
|||
| ``` | |||
| kubectl get vms -o yaml testvm | grep -E 'running:.*|$' | |||
| kubectl get vms -o yaml testvm | grep -E 'runStrategy:.*|$' | |||
There was a problem hiding this comment.
Is the default runStrategy set to effectively be the same as stopped? i.e. if none is specified, does the student still need to verify they are stopped and use virtctl to start them?
There was a problem hiding this comment.
running: true equals runStrategy: Always
and running: false equals runStrategy: Halted
no need to check virtctl.
What this PR does / why we need it:
The .spec.running field is deprecated, therefore we should runStrategy instead.
For more info, look at:
kubevirt/kubevirt#11993i
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: