Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use windows images from artifactory in e2e tests #627

Merged
merged 1 commit into from
Oct 30, 2024
Merged

feat: use windows images from artifactory in e2e tests #627

merged 1 commit into from
Oct 30, 2024

Conversation

ksimon1
Copy link
Member

@ksimon1 ksimon1 commented Oct 22, 2024

What this PR does / why we need it:
feat: use windows images from artifactory in e2e tests

these images will be periodically updated

Release note:

NONE

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 22, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 22, 2024
@ksimon1
Copy link
Member Author

ksimon1 commented Oct 22, 2024

/test e2e-gcp-common-templates-windows10

@kubevirt-bot
Copy link
Contributor

@ksimon1: No presubmit jobs available for kubevirt/common-templates@master

In response to this:

/test e2e-gcp-common-templates-windows10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ksimon1
Copy link
Member Author

ksimon1 commented Oct 22, 2024

/test e2e-gcp-common-templates-windows10

@kubevirt-bot
Copy link
Contributor

@ksimon1: No presubmit jobs available for kubevirt/common-templates@master

In response to this:

/test e2e-gcp-common-templates-windows10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ksimon1 ksimon1 mentioned this pull request Oct 22, 2024
Merged
@ksimon1
Copy link
Member Author

ksimon1 commented Oct 22, 2024

/test e2e-gcp-common-templates-windows10

@kubevirt-bot
Copy link
Contributor

@ksimon1: No presubmit jobs available for kubevirt/common-templates@master

In response to this:

/test e2e-gcp-common-templates-windows10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ksimon1
Copy link
Member Author

ksimon1 commented Oct 22, 2024

/test e2e-gcp-common-templates-windows10

@kubevirt-bot
Copy link
Contributor

@ksimon1: No presubmit jobs available for kubevirt/common-templates@master

In response to this:

/test e2e-gcp-common-templates-windows10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ksimon1
Copy link
Member Author

ksimon1 commented Oct 22, 2024

/test e2e-gcp-common-templates-windows11

@kubevirt-bot
Copy link
Contributor

@ksimon1: No presubmit jobs available for kubevirt/common-templates@master

In response to this:

/test e2e-gcp-common-templates-windows11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ksimon1
Copy link
Member Author

ksimon1 commented Oct 23, 2024

/test e2e-gcp-common-templates-windows11

@kubevirt-bot
Copy link
Contributor

@ksimon1: No presubmit jobs available for kubevirt/common-templates@master

In response to this:

/test e2e-gcp-common-templates-windows11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ksimon1
Copy link
Member Author

ksimon1 commented Oct 23, 2024

/test e2e-gcp-common-templates-windows10

@kubevirt-bot
Copy link
Contributor

@ksimon1: No presubmit jobs available for kubevirt/common-templates@master

In response to this:

/test e2e-gcp-common-templates-windows10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ksimon1
Copy link
Member Author

ksimon1 commented Oct 23, 2024

/test e2e-gcp-common-templates-windows11

@kubevirt-bot
Copy link
Contributor

@ksimon1: No presubmit jobs available for kubevirt/common-templates@master

In response to this:

/test e2e-gcp-common-templates-windows11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ksimon1
Copy link
Member Author

ksimon1 commented Oct 23, 2024

/test e2e-gcp-common-templates-windows10

@kubevirt-bot
Copy link
Contributor

@ksimon1: No presubmit jobs available for kubevirt/common-templates@master

In response to this:

/test e2e-gcp-common-templates-windows10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ksimon1 ksimon1 marked this pull request as ready for review October 23, 2024 17:27
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2024
@kubevirt-bot kubevirt-bot requested a review from jcanocan October 23, 2024 17:27
@ksimon1 ksimon1 changed the title [draft] feat: use windows images from artifactory in e2e tests feat: use windows images from artifactory in e2e tests Oct 23, 2024
@ksimon1
Copy link
Member Author

ksimon1 commented Oct 24, 2024

/retest

@ksimon1
Copy link
Member Author

ksimon1 commented Oct 24, 2024

@akrejcir, @lyarwood can you please review this PR?

@jcanocan
Copy link

Nice job! Looks good to me.

akrejcir
akrejcir reviewed Oct 24, 2024
View reviewed changes
automation/test-windows.sh Outdated
Comment on lines 57 to 58
registry:
registry:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a typo, duplicate line.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed 👍

@ksimon1
Copy link
Member Author

ksimon1 commented Oct 24, 2024

/retest

1 similar comment
@ksimon1
Copy link
Member Author

ksimon1 commented Oct 25, 2024

/retest

@akrejcir
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2024
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2024
@ksimon1 ksimon1 force-pushed the windows-disks branch 2 times, most recently from a9fe747 to 972b469 Compare October 29, 2024 10:01
@ksimon1
feat: use windows images from artifactory
72c3653 
these images will be periodically updated

Signed-off-by: Karel Simon <[email protected]>
@akrejcir
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2024
@ksimon1
Copy link
Member Author

ksimon1 commented Oct 30, 2024

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ksimon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2024
@kubevirt-bot kubevirt-bot merged commit b6a8c99 into kubevirt:master Oct 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrejcir akrejcir akrejcir left review comments

@lyarwood lyarwood Awaiting requested review from lyarwood

@jcanocan jcanocan Awaiting requested review from jcanocan

Assignees

@akrejcir akrejcir

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ksimon1 @kubevirt-bot @jcanocan @akrejcir