Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ssh client to builder image #626

Merged
merged 1 commit into from
Oct 22, 2024
Merged

feat: add ssh client to builder image #626

merged 1 commit into from
Oct 22, 2024

Conversation

ksimon1
Copy link
Member

@ksimon1 ksimon1 commented Oct 21, 2024

What this PR does / why we need it:
feat: add ssh client to builder image

New Windows images in e2e tests will use ssh instead of winrm cli approach.

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 21, 2024
@akrejcir
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2024
@lyarwood
Copy link
Member

/lgtm

@akrejcir with @0xFelix out you will need to ./approve this as the only remaining approver in the OWNERS file

@ksimon1
Copy link
Member Author

ksimon1 commented Oct 21, 2024

/hold
It looks like the openSSH does not allow to pass password via CLI (I know it is insecure, but this is only for e2e tests)

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2024
@ksimon1
feat: add ssh client to builder image
f742060 
New Windows images in e2e tests will use ssh instead of
winrm cli approach.

Signed-off-by: Karel Simon <[email protected]>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2024
@kubevirt-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@ksimon1
Copy link
Member Author

ksimon1 commented Oct 21, 2024

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 21, 2024

@ksimon1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-common-templates-centos-stream9 f742060 link true /test e2e-gcp-common-templates-centos-stream9
ci/prow/e2e-gcp-common-templates-windows10 f742060 link true /test e2e-gcp-common-templates-windows10
ci/prow/e2e-gcp-common-templates-windows11 f742060 link true /test e2e-gcp-common-templates-windows11
ci/prow/e2e-gcp-common-templates-windows2016 f742060 link true /test e2e-gcp-common-templates-windows2016
ci/prow/e2e-gcp-common-templates-windows2019 f742060 link true /test e2e-gcp-common-templates-windows2019
ci/prow/e2e-gcp-common-templates-windows2022 f742060 link true /test e2e-gcp-common-templates-windows2022

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@akrejcir
Copy link
Contributor

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2024
@ksimon1
Copy link
Member Author

ksimon1 commented Oct 22, 2024

the failing tests are not related to this PR. The windows e2e tests will be fixed by #627

@ksimon1 ksimon1 merged commit f1e5d3e into kubevirt:master Oct 22, 2024
11 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyarwood lyarwood Awaiting requested review from lyarwood

@opokornyy opokornyy Awaiting requested review from opokornyy

Assignees

@lyarwood lyarwood

@akrejcir akrejcir

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ksimon1 @akrejcir @lyarwood @kubevirt-bot