Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patching cdi after availability #603

Merged
merged 1 commit into from
Aug 19, 2024
Merged

fix: patching cdi after availability #603

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions automation/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ oc apply -f https://github.com/kubevirt/kubevirt/releases/download/${KUBEVIRT_VE

sample=10
current_time=0
timeout=300
timeout=600

# Waiting for kubevirt cr to report available
oc wait --for=condition=Available --timeout=${timeout}s kubevirt/kubevirt -n $namespace
Expand Down Expand Up @@ -179,10 +179,10 @@ echo "Deploying CDI"
oc apply -f https://github.com/kubevirt/containerized-data-importer/releases/download/$CDI_VERSION/cdi-operator.yaml
oc apply -f https://github.com/kubevirt/containerized-data-importer/releases/download/$CDI_VERSION/cdi-cr.yaml

oc patch cdi cdi -n cdi --patch '{"spec": {"config": {"dataVolumeTTLSeconds": -1}}}' --type merge

oc wait --for=condition=Available --timeout=${timeout}s CDI/cdi -n cdi

oc patch cdi cdi -n cdi --patch '{"spec": {"config": {"dataVolumeTTLSeconds": -1}}}' --type merge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ksimon1 I'm using CodeReady Containers for development on my workstation. While I'm not entirely sure of the underlying reasons, some empirical testing has shown that this change allows the tests to work. Otherwise, they fail when applying the data volumes, as the persistent volume claim is unable to claim any storage.

Additionally, I've encountered the same issue when installing an OpenShift cluster in a VM and running it with QEMU. Do you have any insights into why this might be happening?


oc apply -f - <<EOF
---
apiVersion: rbac.authorization.k8s.io/v1
Expand Down
Loading