fix: patching cdi after availability #603
Conversation
This error was identified while using CodeReady Workspaces with limited resources. The DataVolume specified in the test-linux.sh file did not fully deploy, resulting in failed end-to-end tests. Signed-off-by: Nestor Acuna Blanco <[email protected]>
kubevirt-bot
added
release-note-none
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @nestoracunablanco. Thanks for your PR. I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
| oc wait --for=condition=Available --timeout=${timeout}s CDI/cdi -n cdi | ||
|
|
||
| oc patch cdi cdi -n cdi --patch '{"spec": {"config": {"dataVolumeTTLSeconds": -1}}}' --type merge |
There was a problem hiding this comment.
What is the reason for this change?
There was a problem hiding this comment.
@ksimon1 I'm using CodeReady Containers for development on my workstation. While I'm not entirely sure of the underlying reasons, some empirical testing has shown that this change allows the tests to work. Otherwise, they fail when applying the data volumes, as the persistent volume claim is unable to claim any storage.
Additionally, I've encountered the same issue when installing an OpenShift cluster in a VM and running it with QEMU. Do you have any insights into why this might be happening?
|
@ksimon1 @fossedihelm, do you want any changes to the code? is additional clarification needed for this PR to be merged? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ksimon1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
This error was identified while using CodeReady Workspaces with limited resources. The DataVolume specified in the test-linux.sh file did not fully deploy, resulting in failed end-to-end tests.
What this PR does / why we need it: fixes error
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: