Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve page error messages #4314

Merged
merged 2 commits into from
Sep 25, 2024
Merged

chore: improve page error messages #4314

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8783ed6
chore: improve page error messages
donniean Sep 25, 2024
7777d5e
chore: remove error reason
donniean Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions server/controllers/view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,12 @@ const renderViewErr = async (ctx, err) => {
message: 'Unable to access the api server',
});
} else {
await ctx.render('error', {
title: useDefaultTheme ? defaultTheme?.tabTitle : title,
favicon,
t: ctx.t.bind(ctx),
message: '',
});
ctx.app.emit('error', err);
}
} else {
Expand Down
Loading